Issue 27130. Fix applying changes to .analysis_options on save.

Issue 27130. Fix applying changes to .analysis_options on save.

This fix partially reverts changes made in https://github.com/dart-lang/sdk/commit/de6925a23ebf29cd587dd5f4e214cb277a7397e4
It is correct that we should ignore applyChanges() for sources with
content overridden in the content cache. But we cannot know what else
happened with results in the analysis cache at this point. So, we
should just let Analysis Server to always run analysis, so that
Driver and WorkManager(s) will decide if there is anything to do.

I believe that the original motivation for the change was to avoid
sending extr 'analysis.implemented' notifications. It does not happen
anymore, probably because we set other shortcuts using source content.


R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27130

Committed: https://github.com/dart-lang/sdk/commit/7442a85cbb6f5457b6ea4c299ffcf8772b5d8ab3

[Brian Wilkerson, 2016-09-06 20:37:58]

lgtm

[scheglov, 2016-09-06 20:41:53]

Description was changed from

==========
Issue 27130. Fix applying changes to .analysis_options on save.

This fix partially reverts changes made in
https://github.com/dart-lang/sdk/commit/de6925a23ebf29cd587dd5f4e214cb277a7397e4
It is correct that we should ignore applyChanges() for sources with
content overridden in the content cache. But we cannot know what else
happened with results in the analysis cache at this point. So, we
should just let Analysis Server to always run analysis, so that
Driver and WorkManager(s) will decide if there is anything to do.

I believe that the original motivation for the change was to avoid
sending extr 'analysis.implemented' notifications. It does not happen
anymore, probably because we set other shortcuts using source content.


R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27130
==========

to

==========
Issue 27130. Fix applying changes to .analysis_options on save.

This fix partially reverts changes made in
https://github.com/dart-lang/sdk/commit/de6925a23ebf29cd587dd5f4e214cb277a7397e4
It is correct that we should ignore applyChanges() for sources with
content overridden in the content cache. But we cannot know what else
happened with results in the analysis cache at this point. So, we
should just let Analysis Server to always run analysis, so that
Driver and WorkManager(s) will decide if there is anything to do.

I believe that the original motivation for the change was to avoid
sending extr 'analysis.implemented' notifications. It does not happen
anymore, probably because we set other shortcuts using source content.


R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/27130

Committed:
https://github.com/dart-lang/sdk/commit/7442a85cbb6f5457b6ea4c299ffcf8772b5d8ab3
==========

[scheglov, 2016-09-06 20:41:54]

Committed patchset #1 (id:1) manually as
7442a85cbb6f5457b6ea4c299ffcf8772b5d8ab3 (presubmit successful).