Deprecate HOSTED_NOT_ALLOWED auth error

chrome/browser/signin/signin_global_error_unittest.cc

Index: chrome/browser/signin/signin_global_error_unittest.cc
diff --git a/chrome/browser/signin/signin_global_error_unittest.cc b/chrome/browser/signin/signin_global_error_unittest.cc
index 610273a993e106f47febdc63c3c9833ac3d53ed0..99bd075f25005f7fc419d10e045e11aa3bf694ec 100644
--- a/chrome/browser/signin/signin_global_error_unittest.cc
+++ b/chrome/browser/signin/signin_global_error_unittest.cc
@@ -139,7 +139,7 @@ TEST_F(SigninGlobalErrorTest, AuthStatusEnumerateAllErrors) {
     { GoogleServiceAuthError::SERVICE_UNAVAILABLE, true },
     { GoogleServiceAuthError::TWO_FACTOR, true },
     { GoogleServiceAuthError::REQUEST_CANCELED, true },
-    { GoogleServiceAuthError::HOSTED_NOT_ALLOWED, true },
+    { GoogleServiceAuthError::HOSTED_NOT_ALLOWED_DEPRECATED, true },
     { GoogleServiceAuthError::UNEXPECTED_SERVICE_RESPONSE, true },
     { GoogleServiceAuthError::SERVICE_ERROR, true },
     { GoogleServiceAuthError::WEB_LOGIN_REQUIRED, true },
@@ -151,6 +151,9 @@ TEST_F(SigninGlobalErrorTest, AuthStatusEnumerateAllErrors) {
   testing_profile_manager()->UpdateLastUser(profile());
 
   for (size_t i = 0; i < arraysize(table); ++i) {
+    if (table[i].error_state ==
+        GoogleServiceAuthError::HOSTED_NOT_ALLOWED_DEPRECATED)
+      continue;

[Greg Levin, 2016/09/08 19:56:35]

I couldn't remove HOSTED_NOT_ALLOWED from this table, because the
histogram_tester requires it to align with the enum in histograms.xml (see test
failures in Patch #2).

This code to skip testing HOSTED_NOT_ALLOWED is crude, but simple seemed okay in
this one-off instance.  I also considered adding a |is_deprecated| member to the
struct, or putting HOSTED_NOT_ALLOWED into a singleton set of entries to be
skipped.  Let me know if one of these, or some other approach, sounds better.

[Roger Tawa OOO till Jul 10th, 2016/09/08 21:05:58]

Got it, I see what you mean.  I guess the problem is at line 174 below.  I
wonder if there should be a method like:

static bool GoogleServiceAuthError::IsDeprecated(State state);

to use in the if statement here and the other test file?

     base::HistogramTester histogram_tester;
     FakeAuthStatusProvider provider(error_controller());
     provider.SetAuthError(kTestAccountId,