[promises] Move PromiseResolveThenableJob to c++

src/runtime/runtime-internal.cc

Index: src/runtime/runtime-internal.cc
diff --git a/src/runtime/runtime-internal.cc b/src/runtime/runtime-internal.cc
index 1bc6fcdaf97d55a21ad1495c99cb3ce5492c15e3..e8b9d45dd09874e9c94d0112d2cc01d0f54411c1 100644
--- a/src/runtime/runtime-internal.cc
+++ b/src/runtime/runtime-internal.cc
@@ -555,6 +555,23 @@ RUNTIME_FUNCTION(Runtime_GetAndResetRuntimeCallStats) {
   }
 }
 
+RUNTIME_FUNCTION(Runtime_EnqueuePromiseResolveThenableJob) {
+  HandleScope scope(isolate);
+  DCHECK(args.length() == 7);
+  CONVERT_ARG_HANDLE_CHECKED(JSObject, promise, 0);

[adamk, 2016/09/14 22:52:51]

It looks to me like this argument is unused (see comment in isolate.cc).

+  CONVERT_ARG_HANDLE_CHECKED(JSObject, resolution, 1);

[adamk, 2016/09/14 22:52:51]

Couldn't resolution be a Proxy? I see the call to this runtime function guarded
by IS_RECEIVER(), but I think that includes Proxies. If that's so, this would
need to be a JSReceiver instead of a JSObject. Can you check if there's a test
that ends up passing a Proxy here? It looks like

Promise.resolve(someThenableProxy)

should do the trick.

+  CONVERT_ARG_HANDLE_CHECKED(JSFunction, then, 2);
+  CONVERT_ARG_HANDLE_CHECKED(JSFunction, resolve, 3);
+  CONVERT_ARG_HANDLE_CHECKED(JSFunction, reject, 4);
+  CONVERT_ARG_HANDLE_CHECKED(Object, before_debug_event, 5);
+  CONVERT_ARG_HANDLE_CHECKED(Object, after_debug_event, 6);
+  Handle<PromiseContainer> container = isolate->factory()->NewPromiseContainer(
+      promise, resolution, then, resolve, reject, before_debug_event,
+      after_debug_event);
+  isolate->EnqueueMicrotask(container);
+  return isolate->heap()->undefined_value();
+}
+
 RUNTIME_FUNCTION(Runtime_EnqueueMicrotask) {
   HandleScope scope(isolate);
   DCHECK(args.length() == 1);