third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp - Issue 2314903002: Web Audio: when media playback requires a user gesture, apply rule to cross origin iframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

Issue 2314903002: Web Audio: when media playback requires a user gesture, apply rule to cross origin iframes. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/Deprecation.cpp ('k') | third_party/WebKit/Source/modules/webaudio/AudioContext.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

index 24af794c3037d5967eea07a07b0568ca491d7ff4..4370ce56d8e103eeb43a1ed3e365afad5146a1f5 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

@@ -448,7 +448,7 @@ void AudioBufferSourceHandler::startSource(double when, double grainOffset, doub

{

DCHECK(isMainThread());

- context()->recordUserGestureState();

+ context()->startRenderingIfNeeded();

Raymond Toy 2016/09/08 20:03:33 If we don't have the gesture, we don't want to sta

mlamouri (slow - plz ping) 2016/09/12 17:26:29 This is the intended behaviour, it matches https:/

if (playbackState() != UNSCHEDULED_STATE) {

exceptionState.throwDOMException(