Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

Issue 2314903002: Web Audio: when media playback requires a user gesture, apply rule to cross origin iframes. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp
index 24af794c3037d5967eea07a07b0568ca491d7ff4..4370ce56d8e103eeb43a1ed3e365afad5146a1f5 100644
--- a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp
@@ -448,7 +448,7 @@ void AudioBufferSourceHandler::startSource(double when, double grainOffset, doub
{
DCHECK(isMainThread());
- context()->recordUserGestureState();
+ context()->startRenderingIfNeeded();
Raymond Toy 2016/09/07 16:13:19 I don't think this is right. When the context is
mlamouri (slow - plz ping) 2016/09/08 13:12:42 When the AudioContext is created, it might not be
if (playbackState() != UNSCHEDULED_STATE) {
exceptionState.throwDOMException(

Powered by Google App Engine
This is Rietveld 408576698