dart/sdk/lib/_internal/lib/js_mirrors.dart - Issue 23149002: Don't cache non-Interceptor interceptors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/lib/js_mirrors.dart

Issue 23149002: Don't cache non-Interceptor interceptors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Long lines Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dart/sdk/lib/_internal/lib/js_mirrors.dart

diff --git a/dart/sdk/lib/_internal/lib/js_mirrors.dart b/dart/sdk/lib/_internal/lib/js_mirrors.dart

index 25ca338013bc55ae1f739a0cf0dca130b6874d38..0d51c3f8027bfb7025ef1152a0786e15d0a14760 100644

--- a/dart/sdk/lib/_internal/lib/js_mirrors.dart

+++ b/dart/sdk/lib/_internal/lib/js_mirrors.dart

@@ -505,7 +505,6 @@ class JsInstanceMirror extends JsObjectMirror implements InstanceMirror {

JS('void', r'#.constructor[#] = #', reflectee, cacheName, cache);

}

var cacheEntry = JsCache.fetch(cache, reflectiveName);

- cacheEntry = null; // Work around bug in caching.

var result;

Invocation invocation;

if (cacheEntry == null) {