Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 23149002: Don't cache non-Interceptor interceptors. (Closed)

Created:
7 years, 4 months ago by ahe
Modified:
7 years, 4 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org, zarah
Visibility:
Public.

Description

Don't cache non-Interceptor interceptors. R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=26138

Patch Set 1 #

Patch Set 2 : Added test. #

Patch Set 3 : Long lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -10 lines) Patch
M dart/sdk/lib/_internal/lib/js_helper.dart View 3 chunks +18 lines, -9 lines 0 comments Download
M dart/sdk/lib/_internal/lib/js_mirrors.dart View 1 chunk +0 lines, -1 line 0 comments Download
A dart/tests/lib/mirrors/intercepted_cache_test.dart View 1 2 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ahe
Please take a look at these changes. I'll also write a test before submitting, I ...
7 years, 4 months ago (2013-08-14 00:22:28 UTC) #1
ngeoffray
LGTM
7 years, 4 months ago (2013-08-14 07:31:12 UTC) #2
ahe
Added test as described. Submitting.
7 years, 4 months ago (2013-08-14 19:16:02 UTC) #3
ahe
7 years, 4 months ago (2013-08-14 19:16:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r26138 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698