Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2314883002: Validate that UDIFBlock data length matches the size and reported number of chunks. (Closed)

Created:
4 years, 3 months ago by Robert Sesek
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Validate that UDIFBlock data length matches the size and reported number of chunks. BUG=643726 R=nparker@chromium.org Committed: https://crrev.com/5a29d68e849e2beb122b1ade3a53527a3db04186 Cr-Commit-Position: refs/heads/master@{#416732}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M chrome/utility/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/utility/safe_browsing/mac/udif.cc View 3 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
Robert Sesek
4 years, 3 months ago (2016-09-06 17:27:27 UTC) #3
Nathan Parker
lgtm Any tests to exercise this code?
4 years, 3 months ago (2016-09-06 18:33:56 UTC) #6
Robert Sesek
On 2016/09/06 18:33:56, Nathan Parker wrote: > lgtm > > Any tests to exercise this ...
4 years, 3 months ago (2016-09-06 20:05:09 UTC) #7
Robert Sesek
+thestig for //chrome/utility OWNERS
4 years, 3 months ago (2016-09-06 20:06:01 UTC) #9
Lei Zhang
lgtm
4 years, 3 months ago (2016-09-06 20:53:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314883002/1
4 years, 3 months ago (2016-09-06 21:16:54 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 21:21:45 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 21:23:51 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a29d68e849e2beb122b1ade3a53527a3db04186
Cr-Commit-Position: refs/heads/master@{#416732}

Powered by Google App Engine
This is Rietveld 408576698