Fix bug that causes spurious tab switches.

Fix bug that causes spurious tab switches.

This CL removes the implementation of -[TabView mouseUp:] which should never be
called, since -[TabView mouseDown:] always triggers a nested run loop that
swallows the -[TabView mouseUp:] event. There's an AppKit bug that -[TabView
mouseUp:] on inappropriate views, so it's doubly important that the
implementation not do anything.

BUG=511095
Committed: https://crrev.com/46984b9958ff5af0561a933f6596d85d695cb44d
Cr-Commit-Position: refs/heads/master@{#417368}

[erikchen, 2016-09-07 00:15:48]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 00:16:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 01:02:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 01:02:59]

Dry run: This issue passed the CQ dry run.

[erikchen, 2016-09-07 22:00:48]

erikchen@chromium.org changed reviewers:
+ rsesek@chromium.org

[erikchen, 2016-09-07 22:00:48]

rsesek: Please review.

[Robert Sesek, 2016-09-08 15:15:12]

https://codereview.chromium.org/2314873004/diff/1/chrome/browser/ui/cocoa/tab...
File chrome/browser/ui/cocoa/tabs/tab_view.mm (left):

https://codereview.chromium.org/2314873004/diff/1/chrome/browser/ui/cocoa/tab...
chrome/browser/ui/cocoa/tabs/tab_view.mm:353: // During rapid tab closure
(mashing tab close buttons), we may get hit
Why is this no longer necesary?

https://codereview.chromium.org/2314873004/diff/1/chrome/browser/ui/cocoa/tab...
chrome/browser/ui/cocoa/tabs/tab_view.mm:370: [controller_ selectTab:self];
This is no longer necessary because the super triggers the cell's target-action?
(Or the custom loop in -[TabStripDragController maybeStartDrag:forTab:] does
it).

[erikchen, 2016-09-08 17:09:47]

rsesek: PTAL

https://codereview.chromium.org/2314873004/diff/1/chrome/browser/ui/cocoa/tab...
File chrome/browser/ui/cocoa/tabs/tab_view.mm (left):

https://codereview.chromium.org/2314873004/diff/1/chrome/browser/ui/cocoa/tab...
chrome/browser/ui/cocoa/tabs/tab_view.mm:353: // During rapid tab closure
(mashing tab close buttons), we may get hit
Whoops, still needed.

https://codereview.chromium.org/2314873004/diff/1/chrome/browser/ui/cocoa/tab...
chrome/browser/ui/cocoa/tabs/tab_view.mm:370: [controller_ selectTab:self];
On 2016/09/08 15:15:12, Robert Sesek wrote:
> This is no longer necessary because the super triggers the cell's
target-action?
> (Or the custom loop in -[TabStripDragController maybeStartDrag:forTab:] does
> it).

The nested run loop in -[TabStripDragController maybeStartDrag:forTab:]
processes the mouseUp: event. This code is never called.

[Robert Sesek, 2016-09-08 18:55:53]

LGTM

[erikchen, 2016-09-08 19:01:34]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-09-08 19:03:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 19:46:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-08 19:49:10]

Description was changed from

==========
Fix bug that causes spurious tab switches.

This CL removes the implementation of -[TabView mouseUp:] which should never be
called, since -[TabView mouseDown:] always triggers a nested run loop that
swallows the -[TabView mouseUp:] event. There's an AppKit bug that -[TabView
mouseUp:] on inappropriate views, so it's doubly important that the
implementation not do anything.

BUG=511095
==========

to

==========
Fix bug that causes spurious tab switches.

This CL removes the implementation of -[TabView mouseUp:] which should never be
called, since -[TabView mouseDown:] always triggers a nested run loop that
swallows the -[TabView mouseUp:] event. There's an AppKit bug that -[TabView
mouseUp:] on inappropriate views, so it's doubly important that the
implementation not do anything.

BUG=511095

Committed: https://crrev.com/46984b9958ff5af0561a933f6596d85d695cb44d
Cr-Commit-Position: refs/heads/master@{#417368}
==========

[commit-bot: I haz the power, 2016-09-08 19:49:11]

Patchset 2 (id:??) landed as
https://crrev.com/46984b9958ff5af0561a933f6596d85d695cb44d
Cr-Commit-Position: refs/heads/master@{#417368}