Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: net/tools/quic/end_to_end_test.cc

Issue 2314863003: Fix all Performance and Bug-Prone patterns in quic/core. No functional change. Not flag protected. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/chlo_extractor.h ('k') | net/tools/quic/quic_per_connection_packet_writer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/end_to_end_test.cc
diff --git a/net/tools/quic/end_to_end_test.cc b/net/tools/quic/end_to_end_test.cc
index 4988cc428c41f39a80530f74946aaa72f9035740..127fec715248cd5776f1a69ccd5233e2784b6d27 100644
--- a/net/tools/quic/end_to_end_test.cc
+++ b/net/tools/quic/end_to_end_test.cc
@@ -2165,7 +2165,8 @@ class ServerStreamWithErrorResponseBody : public QuicSimpleServerStream {
ServerStreamWithErrorResponseBody(QuicStreamId id,
QuicSpdySession* session,
string response_body)
- : QuicSimpleServerStream(id, session), response_body_(response_body) {}
+ : QuicSimpleServerStream(id, session),
+ response_body_(std::move(response_body)) {}
~ServerStreamWithErrorResponseBody() override {}
@@ -2187,7 +2188,7 @@ class ServerStreamWithErrorResponseBody : public QuicSimpleServerStream {
class StreamWithErrorFactory : public QuicTestServer::StreamFactory {
public:
explicit StreamWithErrorFactory(string response_body)
- : response_body_(response_body) {}
+ : response_body_(std::move(response_body)) {}
~StreamWithErrorFactory() override {}
@@ -2623,7 +2624,7 @@ TEST_P(EndToEndTestServerPush, ServerPushUnderLimit) {
EXPECT_EQ(kBody, client_->SendSynchronousRequest(
"https://example.com/push_example"));
- for (string url : push_urls) {
+ for (const string& url : push_urls) {
// Sending subsequent requesets will not actually send anything on the wire,
// as the responses are already in the client's cache.
DVLOG(1) << "send request for pushed stream on url " << url;
« no previous file with comments | « net/tools/quic/chlo_extractor.h ('k') | net/tools/quic/quic_per_connection_packet_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698