Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 2314853003: Move ash::DisplayManager switches to ui::display (Closed)

Created:
4 years, 3 months ago by rjkroege
Modified:
4 years, 3 months ago
Reviewers:
stevenjb, oshima, sky
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, alemate+watch_chromium.org, sadrul, asvitkine+watch_chromium.org, tfarina, mlamouri+watch-screen-orientation_chromium.org, achuith+watch_chromium.org, jam, michaelpg+watch-options_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ash::DisplayManager switches to ui::display Further preparation for moving ash::DisplayManager to ui::display by moving the switches needed by ash::DisplayManager to ui::display. BUG=581462 Committed: https://crrev.com/03f3d6b1c4ade7aba34d8fc1c853ec62259407b7 Cr-Commit-Position: refs/heads/master@{#417715}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments #

Patch Set 3 : review comments and rebase #

Patch Set 4 : rebased again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -121 lines) Patch
M ash/accelerators/accelerator_controller_delegate_aura.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/ash_switches.h View 1 2 3 2 chunks +0 lines, -3 lines 0 comments Download
M ash/common/ash_switches.cc View 1 2 3 4 chunks +0 lines, -18 lines 0 comments Download
M ash/common/frame/caption_buttons/frame_caption_button_container_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/frame/custom_frame_view_ash.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/shelf/shelf_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/shelf/shelf_window_watcher_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/system/chromeos/network/network_state_list_detailed_view.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/system/chromeos/network/tray_network.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/system/chromeos/power/tray_power_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/system/status_area_widget_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/system/tray/system_tray.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/system/user/tray_user.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/system/web_notification/web_notification_tray.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/wm/overview/window_selector.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/wm/window_cycle_list.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/content/display/screen_orientation_controller_chromeos_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M ash/dip_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/display/display_change_observer_chromeos.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/display/display_manager.cc View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M ash/display/mirror_window_controller_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/display/screen_ash.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ash/display/window_tree_host_manager_unittest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ash/magnifier/magnification_controller.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ash/shell.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ash/shell/content/client/shell_browser_main_parts.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shell_unittest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M ash/system/overview/overview_button_tray_unittest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M ash/test/ash_test_base.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M ash/test/ash_test_helper.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ash/test/display_manager_test_api.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ash/test/test_suite.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ash/virtual_keyboard_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/virtual_keyboard_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/dock/docked_window_resizer_unittest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/lock_state_controller.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/panels/panel_layout_manager_unittest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/system_gesture_event_filter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_test_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/profiles/profile_list_chromeos_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/display_info_provider_chromeos_unittest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/command_line_pref_store.cc View 2 chunks +20 lines, -19 lines 0 comments Download
M chrome/browser/ui/ash/accelerator_commands_browsertest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/ash_init.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/volume_controller_browsertest_chromeos.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/volume_controller_chromeos.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/base/view_event_test_platform_part_chromeos.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M ui/display/display_switches.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/display/display_switches.cc View 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (11 generated)
rjkroege
PTAL
4 years, 3 months ago (2016-09-06 18:27:41 UTC) #2
oshima
lgtm https://codereview.chromium.org/2314853003/diff/1/ash/display/display_manager.cc File ash/display/display_manager.cc (right): https://codereview.chromium.org/2314853003/diff/1/ash/display/display_manager.cc#newcode16 ash/display/display_manager.cc:16: // nit: remove this
4 years, 3 months ago (2016-09-06 20:09:48 UTC) #3
rjkroege
+sky for OWNERS review on chrome/* https://codereview.chromium.org/2314853003/diff/1/ash/display/display_manager.cc File ash/display/display_manager.cc (right): https://codereview.chromium.org/2314853003/diff/1/ash/display/display_manager.cc#newcode16 ash/display/display_manager.cc:16: // On 2016/09/06 ...
4 years, 3 months ago (2016-09-07 23:12:00 UTC) #5
rjkroege
+ stevenjb@ for chrome/browser/ui/webui/options/*
4 years, 3 months ago (2016-09-07 23:13:22 UTC) #7
sky
chrome LGTM
4 years, 3 months ago (2016-09-08 04:01:02 UTC) #8
stevenjb
chrome/browser/ui/webui/options/ RS LGTM
4 years, 3 months ago (2016-09-08 16:31:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314853003/40001
4 years, 3 months ago (2016-09-08 19:47:45 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/254075)
4 years, 3 months ago (2016-09-08 20:37:01 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314853003/40001
4 years, 3 months ago (2016-09-09 01:39:53 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/277045)
4 years, 3 months ago (2016-09-09 01:46:36 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314853003/60001
4 years, 3 months ago (2016-09-09 20:03:04 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-09 21:29:01 UTC) #22
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 21:32:30 UTC) #24
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/03f3d6b1c4ade7aba34d8fc1c853ec62259407b7
Cr-Commit-Position: refs/heads/master@{#417715}

Powered by Google App Engine
This is Rietveld 408576698