chrome/browser/sync_file_system/task_logger.h - Issue 2314833002: Remove some uses of stl_util's STLDeleteContainerPointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/task_logger.h

Issue 2314833002: Remove some uses of stl_util's STLDeleteContainerPointers. (Closed)

Patch Set: cleanup Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync_file_system/task_logger.h

diff --git a/chrome/browser/sync_file_system/task_logger.h b/chrome/browser/sync_file_system/task_logger.h

index 3197ca71663a4aa1e337bc5d4bfef05ab9e0f443..47bac34f42b3b57d6da0ecbbf133b76d385524af 100644

--- a/chrome/browser/sync_file_system/task_logger.h

+++ b/chrome/browser/sync_file_system/task_logger.h

@@ -31,7 +31,7 @@ class TaskLogger : public base::SupportsWeakPtr<TaskLogger> {

~TaskLog();

};

- typedef std::deque<TaskLog*> LogList;

+ using LogList = std::deque<std::unique_ptr<TaskLog>>;

class Observer {

public:

@@ -57,7 +57,7 @@ class TaskLogger : public base::SupportsWeakPtr<TaskLogger> {

const LogList& GetLog() const;

private:

- std::deque<TaskLog*> log_history_;

+ LogList log_history_;

base::ObserverList<Observer> observers_;