Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2997)

Unified Diff: chrome/browser/chromeos/policy/status_uploader.h

Issue 2314813002: Refactored DeviceStatusCollector to enable truely asynchronous status queries (Closed)
Patch Set: Initialize *status_ in the C++11'y way Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/status_uploader.h
diff --git a/chrome/browser/chromeos/policy/status_uploader.h b/chrome/browser/chromeos/policy/status_uploader.h
index 877c8214123c186a9f5b142a90b0523194dbbad5..9cbefceca217e5b9a282147b1a661e5f803b4a5b 100644
--- a/chrome/browser/chromeos/policy/status_uploader.h
+++ b/chrome/browser/chromeos/policy/status_uploader.h
@@ -111,37 +111,6 @@ class StatusUploader : public MediaCaptureDevicesDispatcher::Observer {
// invalidate the weak pointers before any other members are destroyed.
base::WeakPtrFactory<StatusUploader> weak_factory_;
- // Small helper class for state tracking. Necessary because
- // DeviceStatusCollector has two independent async calls for getting device
- // and session status, but we need BOTH results before we can upload data.
- class StatusGetter : public base::RefCountedThreadSafe<StatusGetter> {
- public:
- explicit StatusGetter(const base::WeakPtr<StatusUploader>& uploader);
-
- void OnDeviceStatusReceived(
- std::unique_ptr<enterprise_management::DeviceStatusReportRequest>
- device_status);
- void OnSessionStatusReceived(
- std::unique_ptr<enterprise_management::SessionStatusReportRequest>
- session_status);
-
- private:
- friend class RefCountedThreadSafe<StatusGetter>;
- ~StatusGetter();
-
- void CheckDone();
-
- std::unique_ptr<enterprise_management::DeviceStatusReportRequest>
- device_status_;
- std::unique_ptr<enterprise_management::SessionStatusReportRequest>
- session_status_;
-
- base::WeakPtr<StatusUploader> uploader_;
-
- bool device_status_response_received_;
- bool session_status_response_received_;
- };
-
DISALLOW_COPY_AND_ASSIGN(StatusUploader);
};

Powered by Google App Engine
This is Rietveld 408576698