Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2314803002: [heap] Switch to 500k pages (Closed)

Created:
4 years, 3 months ago by Michael Lippautz
Modified:
4 years, 3 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Switch to 500k pages BUG=chromium:636331 R=ulan@chromium.org Committed: https://crrev.com/4b618dbf8ec7f0edf377b54b48bf3c852d5e235a Cr-Commit-Position: refs/heads/master@{#39220}

Patch Set 1 #

Patch Set 2 : Fixes #

Patch Set 3 : Slack for LO space limit #

Patch Set 4 : Fix LO space limit #

Patch Set 5 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M src/base/build_config.h View 1 chunk +1 line, -1 line 0 comments Download
M src/globals.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/heap/mark-compact.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/heap/spaces.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/heap/test-heap.cc View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download
M test/cctest/heap/test-mark-compact.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (23 generated)
Michael Lippautz
4 years, 3 months ago (2016-09-06 17:19:14 UTC) #17
ulan
lgtm
4 years, 3 months ago (2016-09-06 17:30:32 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314803002/80001
4 years, 3 months ago (2016-09-06 17:52:37 UTC) #24
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 3 months ago (2016-09-06 17:54:56 UTC) #26
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/4b618dbf8ec7f0edf377b54b48bf3c852d5e235a Cr-Commit-Position: refs/heads/master@{#39220}
4 years, 3 months ago (2016-09-06 17:55:46 UTC) #28
Michael Achenbach
4 years, 3 months ago (2016-09-07 06:31:31 UTC) #29
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2312853005/ by machenbach@chromium.org.

The reason for reverting is: Breaks arm64 nosnap debug:
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%....

Powered by Google App Engine
This is Rietveld 408576698