Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 2314763003: Mojo C++ bindings: add perf tests to compare performance of Router/MultiplexRouter. (Closed)

Created:
4 years, 3 months ago by yzshen1
Modified:
4 years, 3 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: add perf tests to compare performance of Router/MultiplexRouter. These two test cases do same-thread ping-pong using Router and MultiplexRouter: MultiplexRouter is about 95% as fast as Router: [ RUN ] MojoBindingsPerftest.RouterPingPong RouterPingPong/ 144546 pings/second [ OK ] MojoBindingsPerftest.RouterPingPong (702 ms) [ RUN ] MojoBindingsPerftest.MultiplexRouterPingPong MultiplexRouterPingPong/ 137701 pings/second BUG=594244 Committed: https://crrev.com/8080848e3e4694cfb6fb84cd842b0b526b60263c Cr-Commit-Position: refs/heads/master@{#416761}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -0 lines) Patch
M mojo/public/cpp/bindings/tests/bindings_perftest.cc View 1 2 chunks +117 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
4 years, 3 months ago (2016-09-06 19:23:38 UTC) #6
Ken Rockot(use gerrit already)
lgtm
4 years, 3 months ago (2016-09-06 21:31:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314763003/20001
4 years, 3 months ago (2016-09-06 21:42:21 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-06 23:15:54 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 23:20:00 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8080848e3e4694cfb6fb84cd842b0b526b60263c
Cr-Commit-Position: refs/heads/master@{#416761}

Powered by Google App Engine
This is Rietveld 408576698