third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp - Issue 2314763002: Replace collectLayerFragments() with FragmentainerIterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp

Issue 2314763002: Replace collectLayerFragments() with FragmentainerIterator. (Closed)

Patch Set: code review. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp b/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp

index d3452bcc13463522bd1bbbb9d673da64e22637b8..d369fa4120afbd27926db96eb2019e56c03508a7 100644

--- a/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp

@@ -419,12 +419,6 @@ LayoutRect LayoutMultiColumnSet::fragmentsBoundingBox(const LayoutRect& bounding

return result;

}

-void LayoutMultiColumnSet::collectLayerFragments(PaintLayerFragments& fragments, const LayoutRect& layerBoundingBox, const LayoutRect& dirtyRect)

- for (const auto& group : m_fragmentainerGroups)

- group.collectLayerFragments(fragments, layerBoundingBox, dirtyRect);

void LayoutMultiColumnSet::addOverflowFromChildren()

{

LayoutRect overflowRect;