Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Unified Diff: build/config/compiler/BUILD.gn

Issue 2314753002: mac: remove libc++-static 10.6 compatibility hack (Closed)
Patch Set: undelete Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | third_party/libc++-static/LICENSE.TXT » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 7f4578d80b614254fad0d8eb080b9df472e851fa..5004ad784d84ab1530e284df9eae8b3d56fb3c88 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -404,34 +404,8 @@ config("compiler") {
}
if (is_mac) {
Nico 2016/09/12 20:27:12 Maybe add a ` # TODO: Remove once we raise the dep
- # Tell the compiler to use libc++'s headers and the linker to link
- # against libc++. The latter part normally requires OS X 10.7,
- # but we still support running on 10.6. How does this work? Two
- # parts:
- # 1. Chromium's clang doesn't error on -mmacosx-version-min=10.6
- # combined with -stdlib=libc++ (it normally silently produced a
- # binary that doesn't run on 10.6)
- # 2. Further down, library_dirs is set to
- # third_party/libc++-static, which contains a static
- # libc++.a library. The linker then links against that instead
- # of against /usr/lib/libc++.dylib when it sees the -lc++ flag
- # added by the driver.
- #
- # In component builds, just link to the system libc++. This has
- # the effect of making everything depend on libc++, which means
- # component-build binaries won't run on 10.6 (no libc++ there),
- # but for a developer-only configuration that's ok. (We don't
- # want to raise the deployment target yet so that official and
- # dev builds have the same deployment target. This affects
- # things like which functions are considered deprecated.)
cflags_cc += [ "-stdlib=libc++" ]
ldflags += [ "-stdlib=libc++" ]
- if (!is_component_build && !is_asan) {
- ldflags += [
- "-L",
- rebase_path("//third_party/libc++-static", root_build_dir),
- ]
- }
}
# Add flags for link-time optimization. These flags enable
« no previous file with comments | « DEPS ('k') | third_party/libc++-static/LICENSE.TXT » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698