mac: remove libc++-static 10.6 compatibility hack

mac: remove libc++-static 10.6 compatibility hack

This hack is obsolete since the minimum supported Mac version is now 10.9.

This CL also removes the checked-in copy of libc++-static, and removes
it from DEPS.

BUG=

Committed: https://crrev.com/9fe8c63c54c0a0c4fd420518962e462cc00f9f65
Cr-Commit-Position: refs/heads/master@{#418584}

[Elly Fong-Jones, 2016-09-06 11:47:41]

Description was changed from

==========
mac: remove libc++-static 10.6 compatibility hack

This hack is obsolete since the minimum supported Mac version is now 10.9.

This CL also removes the checked-in copy of libc++-static, and removes
it from DEPS.

BUG=
==========

to

==========
mac: remove libc++-static 10.6 compatibility hack

This hack is obsolete since the minimum supported Mac version is now 10.9.

This CL also removes the checked-in copy of libc++-static, and removes
it from DEPS.

BUG=
==========

[Elly Fong-Jones, 2016-09-06 11:47:41]

ellyjones@chromium.org changed reviewers:
+ thakis@chromium.org

[Elly Fong-Jones, 2016-09-06 11:47:59]

thakis@: ptal? mark@ mentioned on friday that we should do this :)

[Elly Fong-Jones, 2016-09-06 11:48:08]

The CQ bit was checked by ellyjones@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 11:48:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 11:59:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 11:59:07]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Mark Mentovai, 2016-09-12 18:33:26]

I believe that this is why your try job was red.

https://codereview.chromium.org/2314753002/diff/1/build/config/compiler/BUILD.gn
File build/config/compiler/BUILD.gn (left):

https://codereview.chromium.org/2314753002/diff/1/build/config/compiler/BUILD...
build/config/compiler/BUILD.gn:427: cflags_cc += [ "-stdlib=libc++" ]
We still need -stdlib, until we finally get our deployment target bumped to 10.8
or higher.

https://codereview.chromium.org/2314753002/diff/1/build/config/compiler/BUILD...
build/config/compiler/BUILD.gn:429: if (!is_component_build && !is_asan) {
But this stuff, and the long comment in this block, are no longer necessary.

[Nico, 2016-09-12 18:47:30]

We (Elly and I) talked about this last Friday and I forgot to update the thread.

I believe that medium term, we'll end up shipping statically linking some C++
standard library everywhere*. We've always done that on Windows and Android. I
think we'll start doing this on Linux fairly soon (dcheng and I are working on
this). As I go on for some detail in
http://blog.llvm.org/2015/01/using-clang-for-chrome-production.html , I think
that with C++ updating at a higher pace, having a "system C++ library" kind of
stops making sense – and people will eventually want to use some of the new
library things that they're cooking up for 17. I'm indifferent about not
statically linking libc++ on OS X until we actually need to do that again, so if
someone wants to land this patch that's fine with me. But I think eventually
somewhat soon we'll reland something along those lines.

As Mark says, we still need the -stdlib= flags in any case.

*: …except iOS

[Mark Mentovai, 2016-09-12 18:50:37]

mark@chromium.org changed reviewers:
+ mark@chromium.org

[Mark Mentovai, 2016-09-12 18:50:37]

I think we should go back to the system library, saving a few bytes sharing a
bit more code. If we need to ship our own copy again in the future, that’s fine,
but I don’t think we can draw any conclusions about that longer-term issue now.
We don’t yet know, for example, what the OS policy for C++ runtime library
updates will be with this newer, faster C++ evolution.

[Mark Mentovai, 2016-09-12 18:50:50]

mark@chromium.org changed reviewers:
- mark@chromium.org

[Elly Fong-Jones, 2016-09-12 20:23:17]

The CQ bit was checked by ellyjones@chromium.org to run a CQ dry run

[Elly Fong-Jones, 2016-09-12 20:23:36]

On 2016/09/12 18:50:37, Mark Mentovai wrote:
> I think we should go back to the system library, saving a few bytes sharing a
> bit more code. If we need to ship our own copy again in the future, that’s
fine,
> but I don’t think we can draw any conclusions about that longer-term issue
now.
> We don’t yet know, for example, what the OS policy for C++ runtime library
> updates will be with this newer, faster C++ evolution.

thakis@: can you review this change? I think the right thing to do is delete
this library.

[commit-bot: I haz the power, 2016-09-12 20:23:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-09-12 20:27:13]

Fair enough, lgtm.

https://codereview.chromium.org/2314753002/diff/20001/build/config/compiler/B...
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/2314753002/diff/20001/build/config/compiler/B...
build/config/compiler/BUILD.gn:406: if (is_mac) {
Maybe add a ` # TODO: Remove once we raise the deployment target to 10.9` (or
whatever the deployment target is where clang defaults to libc++ … yup, 10.9
according to clang's source). Up to you.

[commit-bot: I haz the power, 2016-09-12 21:03:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 21:03:26]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Elly Fong-Jones, 2016-09-14 15:31:25]

The CQ bit was checked by ellyjones@chromium.org

[Elly Fong-Jones, 2016-09-14 15:31:25]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2314753002/#ps40001
(title: "remove libc++ check in verify_order")

[commit-bot: I haz the power, 2016-09-14 15:31:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 16:35:00]

Description was changed from

==========
mac: remove libc++-static 10.6 compatibility hack

This hack is obsolete since the minimum supported Mac version is now 10.9.

This CL also removes the checked-in copy of libc++-static, and removes
it from DEPS.

BUG=
==========

to

==========
mac: remove libc++-static 10.6 compatibility hack

This hack is obsolete since the minimum supported Mac version is now 10.9.

This CL also removes the checked-in copy of libc++-static, and removes
it from DEPS.

BUG=
==========

[commit-bot: I haz the power, 2016-09-14 16:35:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-14 16:37:08]

Description was changed from

==========
mac: remove libc++-static 10.6 compatibility hack

This hack is obsolete since the minimum supported Mac version is now 10.9.

This CL also removes the checked-in copy of libc++-static, and removes
it from DEPS.

BUG=
==========

to

==========
mac: remove libc++-static 10.6 compatibility hack

This hack is obsolete since the minimum supported Mac version is now 10.9.

This CL also removes the checked-in copy of libc++-static, and removes
it from DEPS.

BUG=

Committed: https://crrev.com/9fe8c63c54c0a0c4fd420518962e462cc00f9f65
Cr-Commit-Position: refs/heads/master@{#418584}
==========

[commit-bot: I haz the power, 2016-09-14 16:37:09]

Patchset 3 (id:??) landed as
https://crrev.com/9fe8c63c54c0a0c4fd420518962e462cc00f9f65
Cr-Commit-Position: refs/heads/master@{#418584}