Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 2314723003: Add harness-tests/crash.html and harness-tests/timeout.html (Closed)

Created:
4 years, 3 months ago by Xianzhu
Modified:
4 years, 3 months ago
Reviewers:
qyearsley, wkorman
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add harness-tests/crash.html and harness-tests/timeout.html These tests will test if the layout test system can correctly detect the failures. For now crashing tests flakily timeout on Mac10.9. BUG=644303 Committed: https://crrev.com/49e72e2d3bff0aa65d41133e86c386105be311e7 Cr-Commit-Position: refs/heads/master@{#416682}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/harness-tests/crash.html View 1 chunk +4 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/harness-tests/timeout.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.idl View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
Xianzhu
4 years, 3 months ago (2016-09-06 17:24:12 UTC) #5
wkorman
lgtm
4 years, 3 months ago (2016-09-06 17:32:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314723003/1
4 years, 3 months ago (2016-09-06 18:43:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 18:49:12 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 18:51:12 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/49e72e2d3bff0aa65d41133e86c386105be311e7
Cr-Commit-Position: refs/heads/master@{#416682}

Powered by Google App Engine
This is Rietveld 408576698