tests/compiler/dart2js/simple_inferrer_test.dart - Issue 2314703002: Split World usage into open, inference, and closed world.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/simple_inferrer_test.dart

Issue 2314703002: Split World usage into open, inference, and closed world. (Closed)

Patch Set: Updated cf. comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tests/compiler/dart2js/simple_inferrer_closure_test.dart ('k') | tests/compiler/dart2js/simple_inferrer_try_catch_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/compiler/dart2js/simple_inferrer_test.dart

diff --git a/tests/compiler/dart2js/simple_inferrer_test.dart b/tests/compiler/dart2js/simple_inferrer_test.dart

index 295784ad3b085645d259301a5053681883ad78a0..c6f97d509d1f08dd34f45ad6599828347c839842 100644

--- a/tests/compiler/dart2js/simple_inferrer_test.dart

+++ b/tests/compiler/dart2js/simple_inferrer_test.dart

@@ -729,7 +729,7 @@ void main() {

asyncTest(() => compiler.run(uri).then((_) {

var commonMasks = compiler.commonMasks;

var typesInferrer = compiler.globalInference.typesInferrer;

- var world = compiler.world;

+ var world = compiler.closedWorld;

checkReturn(String name, type) {

var element = findElement(compiler, name);

@@ -758,7 +758,7 @@ void main() {

checkReturn('returnEmpty1', const TypeMask.nonNullEmpty());

checkReturn('returnEmpty2', const TypeMask.nonNullEmpty());

TypeMask intType = new TypeMask.nonNullSubtype(

- compiler.coreClasses.intClass, compiler.world);

+ compiler.coreClasses.intClass, compiler.closedWorld);

checkReturn('testIsCheck1', intType);

checkReturn('testIsCheck2', intType);

checkReturn('testIsCheck3', intType.nullable());

@@ -791,7 +791,7 @@ void main() {

checkReturn('testIf1', commonMasks.uint31Type.nullable());

checkReturn('testIf2', commonMasks.uint31Type.nullable());

checkReturn('returnAsString', new TypeMask.subtype(

- compiler.coreClasses.stringClass, compiler.world));

+ compiler.coreClasses.stringClass, compiler.closedWorld));

checkReturn('returnIntAsNum', commonMasks.uint31Type);

checkReturn('returnAsTypedef', commonMasks.functionType.nullable());

checkReturn('returnTopLevelGetter', commonMasks.uint31Type);

@@ -799,7 +799,7 @@ void main() {

checkReturn('testLabeledIf', commonMasks.uint31Type.nullable());

checkReturn('testSwitch1', simplify(

commonMasks.intType

- .union(commonMasks.doubleType, compiler.world)

+ .union(commonMasks.doubleType, compiler.closedWorld)

.nullable(),

compiler));

checkReturn('testSwitch2', commonMasks.uint31Type);