pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart - Issue 2314703002: Split World usage into open, inference, and closed world.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

Issue 2314703002: Split World usage into open, inference, and closed world. (Closed)

Patch Set: Updated cf. comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart ('k') | pkg/compiler/lib/src/js_emitter/type_test_registry.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

diff --git a/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart b/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

index efec052e37bd4eba4be5b2e4340d662a0334e658..51d2f57b5e1512a317901e4322fabcbe3ab0452b 100644

--- a/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

+++ b/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

@@ -671,7 +671,7 @@ class ProgramBuilder {

bool _methodCanBeApplied(FunctionElement method) {

return _compiler.enabledFunctionApply &&

- _compiler.world.getMightBePassedToApply(method);

+ _compiler.closedWorld.getMightBePassedToApply(method);

}

// TODO(herhut): Refactor incremental compilation and remove method.

@@ -731,8 +731,9 @@ class ProgramBuilder {

isClosureCallMethod = true;

} else {

// Careful with operators.

- canTearOff = universe.hasInvokedGetter(element, _compiler.world) ||

- (canBeReflected && !element.isOperator);

+ canTearOff =

+ universe.hasInvokedGetter(element, _compiler.closedWorld) ||

+ (canBeReflected && !element.isOperator);

assert(canTearOff ||

!universe.methodsNeedingSuperGetter.contains(element));

tearOffName = namer.getterForElement(element);