Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Side by Side Diff: tests/compiler/dart2js/gvn_dynamic_field_get_test.dart

Issue 2314703002: Split World usage into open, inference, and closed world. (Closed)
Patch Set: Updated cf. comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // Test that dart2js gvns dynamic getters that don't have side 4 // Test that dart2js gvns dynamic getters that don't have side
5 // effects. 5 // effects.
6 6
7 import 'package:expect/expect.dart'; 7 import 'package:expect/expect.dart';
8 import 'package:async_helper/async_helper.dart'; 8 import 'package:async_helper/async_helper.dart';
9 import 'compiler_helper.dart'; 9 import 'compiler_helper.dart';
10 import 'package:compiler/src/universe/selector.dart' show Selector; 10 import 'package:compiler/src/universe/selector.dart' show Selector;
(...skipping 18 matching lines...) Expand all
29 String generated = compiler.assembledCode; 29 String generated = compiler.assembledCode;
30 RegExp regexp = new RegExp(r"get\$foo"); 30 RegExp regexp = new RegExp(r"get\$foo");
31 Iterator matches = regexp.allMatches(generated).iterator; 31 Iterator matches = regexp.allMatches(generated).iterator;
32 checkNumberOfMatches(matches, 1); 32 checkNumberOfMatches(matches, 1);
33 var cls = findElement(compiler, 'A'); 33 var cls = findElement(compiler, 'A');
34 Expect.isNotNull(cls); 34 Expect.isNotNull(cls);
35 String name = 'foo'; 35 String name = 'foo';
36 var element = cls.lookupLocalMember(name); 36 var element = cls.lookupLocalMember(name);
37 Expect.isNotNull(element); 37 Expect.isNotNull(element);
38 Selector selector = new Selector.getter(new PublicName(name)); 38 Selector selector = new Selector.getter(new PublicName(name));
39 Expect.isFalse(compiler.world.hasAnyUserDefinedGetter(selector, null)); 39 Expect.isFalse(
40 compiler.closedWorld.hasAnyUserDefinedGetter(selector, null));
40 })); 41 }));
41 } 42 }
OLDNEW
« no previous file with comments | « tests/compiler/dart2js/field_type_simple_inferer_test.dart ('k') | tests/compiler/dart2js/jsinterop/world_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698