Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: pkg/compiler/lib/src/js_backend/field_naming_mixin.dart

Issue 2314703002: Split World usage into open, inference, and closed world. (Closed)
Patch Set: Updated cf. comments. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of js_backend.namer; 5 part of js_backend.namer;
6 6
7 abstract class _MinifiedFieldNamer implements Namer { 7 abstract class _MinifiedFieldNamer implements Namer {
8 _FieldNamingRegistry get fieldRegistry; 8 _FieldNamingRegistry get fieldRegistry;
9 9
10 // Returns a minimal name for the field that is globally unique along 10 // Returns a minimal name for the field that is globally unique along
11 // the given element's class inheritance chain. 11 // the given element's class inheritance chain.
12 // 12 //
13 // The inheritance scope based naming might not yield a name. For instance, 13 // The inheritance scope based naming might not yield a name. For instance,
14 // this could be because the field belongs to a mixin. In such a case this 14 // this could be because the field belongs to a mixin. In such a case this
15 // will return `null` and a normal field name has to be used. 15 // will return `null` and a normal field name has to be used.
16 jsAst.Name _minifiedInstanceFieldPropertyName(Element element) { 16 jsAst.Name _minifiedInstanceFieldPropertyName(Element element) {
17 if (backend.nativeData.hasFixedBackendName(element)) { 17 if (backend.nativeData.hasFixedBackendName(element)) {
18 return new StringBackedName( 18 return new StringBackedName(
19 backend.nativeData.getFixedBackendName(element)); 19 backend.nativeData.getFixedBackendName(element));
20 } 20 }
21 21
22 _FieldNamingScope names; 22 _FieldNamingScope names;
23 if (element is BoxFieldElement) { 23 if (element is BoxFieldElement) {
24 names = new _FieldNamingScope.forBox(element.box, fieldRegistry); 24 names = new _FieldNamingScope.forBox(element.box, fieldRegistry);
25 } else { 25 } else {
26 ClassElement cls = element.enclosingClass; 26 ClassElement cls = element.enclosingClass;
27 names = 27 names = new _FieldNamingScope.forClass(
28 new _FieldNamingScope.forClass(cls, compiler.world, fieldRegistry); 28 cls, compiler.closedWorld, fieldRegistry);
29 } 29 }
30 30
31 if (names.containsField(element)) { 31 if (names.containsField(element)) {
32 return names[element]; 32 return names[element];
33 } 33 }
34 return null; 34 return null;
35 } 35 }
36 } 36 }
37 37
38 /** 38 /**
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 : super.rootScope(box, registry); 227 : super.rootScope(box, registry);
228 228
229 @override 229 @override
230 bool containsField(_) => true; 230 bool containsField(_) => true;
231 231
232 jsAst.Name operator [](Element field) { 232 jsAst.Name operator [](Element field) {
233 if (!names.containsKey(field)) add(field); 233 if (!names.containsKey(field)) add(field);
234 return names[field]; 234 return names[field];
235 } 235 }
236 } 236 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698