Add support for directory access to the file system API.

chrome/browser/extensions/api/file_handlers/app_file_handler_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/file_handlers/app_file_handler_util.h"
 
 #include "base/file_util.h"
 #include "base/files/file_path.h"
 #include "chrome/browser/extensions/extension_prefs.h"
 #include "content/public/browser/browser_thread.h"
@@ skipping 41 matching lines @@
     const FileHandlerInfo& handler,
     const std::string& mime_type) {
   for (std::set<std::string>::const_iterator type = handler.types.begin();
        type != handler.types.end(); ++type) {
     if (net::MatchesMimeType(*type, mime_type))
       return true;
   }
   return false;
 }
 
-bool DoCheckWritableFile(const base::FilePath& path) {
+bool DoCheckWritableFile(const base::FilePath& path, bool is_directory) {
   // Don't allow links.
   if (base::PathExists(path) && file_util::IsLink(path))
     return false;
 
+  if (is_directory)
+    // CreateDirectory returns true if the directory already exists.
+    return file_util::CreateDirectory(path);

[benwells, 2013/08/29 00:04:24]

I'm not sure about this. Can we return file_util::DirectoryExists()?

[Sam McNally, 2013/08/29 00:16:08]

Done.

+
   // Create the file if it doesn't already exist.
   base::PlatformFileError error = base::PLATFORM_FILE_OK;
   int creation_flags = base::PLATFORM_FILE_CREATE |
                        base::PLATFORM_FILE_READ |
                        base::PLATFORM_FILE_WRITE;
   base::PlatformFile file = base::CreatePlatformFile(path, creation_flags,
                                                      NULL, &error);
   // Close the file so we don't keep a lock open.
   if (file != base::kInvalidPlatformFileValue)
     base::ClosePlatformFile(file);
   if (error != base::PLATFORM_FILE_OK &&
       error != base::PLATFORM_FILE_ERROR_EXISTS) {
     return false;
   }
 
   return true;
 }
 
 // Checks whether a list of paths are all OK for writing and calls a provided
 // on_success or on_failure callback when done. A file is OK for writing if it
 // is not a symlink, is not in a blacklisted path and can be opened for writing;
 // files are created if they do not exist.
 class WritableFileChecker
     : public base::RefCountedThreadSafe<WritableFileChecker> {
  public:
   WritableFileChecker(
       const std::vector<base::FilePath>& paths,
       Profile* profile,
+      bool is_directory,
       const base::Closure& on_success,
       const base::Callback<void(const base::FilePath&)>& on_failure);
 
   void Check();
 
  private:
   friend class base::RefCountedThreadSafe<WritableFileChecker>;
   virtual ~WritableFileChecker();
 
   // Called when a work item is completed. If all work items are done, this
   // calls the success or failure callback.
   void TaskDone();
 
   // Reports an error in completing a work item. This may be called more than
   // once, but only the last message will be retained.
   void Error(const base::FilePath& error_path);
 
   void CheckLocalWritableFiles();
 
 #if defined(OS_CHROMEOS)
   void CheckRemoteWritableFile(const base::FilePath& remote_path,
                                drive::FileError error,
                                const base::FilePath& local_path);
 #endif
 
   const std::vector<base::FilePath> paths_;
   Profile* profile_;
+  const bool is_directory_;
   int outstanding_tasks_;
   base::FilePath error_path_;
   base::Closure on_success_;
   base::Callback<void(const base::FilePath&)> on_failure_;
 };
 
 WritableFileChecker::WritableFileChecker(
     const std::vector<base::FilePath>& paths,
     Profile* profile,
+    bool is_directory,
     const base::Closure& on_success,
     const base::Callback<void(const base::FilePath&)>& on_failure)
     : paths_(paths),
       profile_(profile),
+      is_directory_(is_directory),
       outstanding_tasks_(1),
       on_success_(on_success),
       on_failure_(on_failure) {}
 
 void WritableFileChecker::Check() {
 #if defined(OS_CHROMEOS)
   if (drive::util::IsUnderDriveMountPoint(paths_[0])) {
     outstanding_tasks_ = paths_.size();
     for (std::vector<base::FilePath>::const_iterator it = paths_.begin();
          it != paths_.end();
@@ skipping 32 matching lines @@
   error_path_ = error_path;
   TaskDone();
 }
 
 void WritableFileChecker::CheckLocalWritableFiles() {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE));
   std::string error;
   for (std::vector<base::FilePath>::const_iterator it = paths_.begin();
        it != paths_.end();
        ++it) {
-    if (!DoCheckWritableFile(*it)) {
+    if (!DoCheckWritableFile(*it, is_directory_)) {
       content::BrowserThread::PostTask(
           content::BrowserThread::UI,
           FROM_HERE,
           base::Bind(&WritableFileChecker::Error, this, *it));
       return;
     }
   }
   content::BrowserThread::PostTask(
       content::BrowserThread::UI,
       FROM_HERE,
@@ skipping 85 matching lines @@
     const std::string& mime_type,
     const base::FilePath& path) {
   return FileHandlerCanHandleFileWithMimeType(handler, mime_type) ||
       FileHandlerCanHandleFileWithExtension(handler, path);
 }
 
 GrantedFileEntry CreateFileEntry(
     Profile* profile,
     const Extension* extension,
     int renderer_id,
-    const base::FilePath& path) {
+    const base::FilePath& path,
+    bool is_directory) {
   GrantedFileEntry result;
   fileapi::IsolatedContext* isolated_context =
       fileapi::IsolatedContext::GetInstance();
   DCHECK(isolated_context);
 
   result.filesystem_id = isolated_context->RegisterFileSystemForPath(
       fileapi::kFileSystemTypeNativeForPlatformApp, path,
       &result.registered_name);
 
   content::ChildProcessSecurityPolicy* policy =
       content::ChildProcessSecurityPolicy::GetInstance();
   policy->GrantReadFileSystem(renderer_id, result.filesystem_id);
-  if (HasFileSystemWritePermission(extension))
+  if (HasFileSystemWritePermission(extension)) {
     policy->GrantWriteFileSystem(renderer_id, result.filesystem_id);
+    if (is_directory)
+      policy->GrantCreateFileForFileSystem(renderer_id, result.filesystem_id);
+  }
 
   result.id = result.filesystem_id + ":" + result.registered_name;
   return result;
 }
 
 void CheckWritableFiles(
     const std::vector<base::FilePath>& paths,
     Profile* profile,
+    bool is_directory,
     const base::Closure& on_success,
     const base::Callback<void(const base::FilePath&)>& on_failure) {
-  scoped_refptr<WritableFileChecker> checker(
-      new WritableFileChecker(paths, profile, on_success, on_failure));
+  scoped_refptr<WritableFileChecker> checker(new WritableFileChecker(
+      paths, profile, is_directory, on_success, on_failure));
   checker->Check();
 }
 
+GrantedFileEntry::GrantedFileEntry() {}
+
 bool HasFileSystemWritePermission(const Extension* extension) {
   return extension->HasAPIPermission(APIPermission::kFileSystemWrite);
 }
 
 }  // namespace app_file_handler_util
 
 }  // namespace extensions