[WIN] Remove "Pin this program to taskbar" of panel window.

[WIN] Remove  "Pin this program to taskbar" of panel window.

Panel windows are created and used by the extensions. When they are pinned to the taskbar, the icon will change to Chrome instead of the original icon. What's more, the relaunch behavior (Close all panel windows and then click the pinned icon will open a chrome new window) will confuse the user.
why we can't implement the support to pin the panel window on the taskbar? It is because launching chrome executable with extension app_id (in this case, hangout id), will launch chrome browser with Hangout options page, instead of the chat window.

BUG=270844
TEST=1. Install Google Hangout extension and launch it; 2. From windows taskbar, right click on Hangout.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218949

[jianli, 2013-08-19 18:39:53]

Please explain in the patch description why we can't pin the Hangout window or
panel window to the taskbar.

Also please ask the ui owner to review this change.

https://codereview.chromium.org/23146009/diff/1/ui/base/win/shell.h
File ui/base/win/shell.h (right):

https://codereview.chromium.org/23146009/diff/1/ui/base/win/shell.h#newcode46
ui/base/win/shell.h:46: UI_EXPORT bool PreventWinowPinning(HWND hwnd);
typo: Winow.

consider name the function as PreventWindowFromPinning or DisableWindowPinning

[zhchbin, 2013-08-20 06:26:34]

> Also please ask the ui owner to review this change.

Could you please help me figure out who should be the ui owner? I'm not a
googler.

> Please explain in the patch description why we can't
> pin the Hangout window or panel window to the taskbar.

Done.

https://codereview.chromium.org/23146009/diff/1/ui/base/win/shell.h
File ui/base/win/shell.h (right):

https://codereview.chromium.org/23146009/diff/1/ui/base/win/shell.h#newcode46
ui/base/win/shell.h:46: UI_EXPORT bool PreventWinowPinning(HWND hwnd);
On 2013/08/19 18:39:54, jianli wrote:
> typo: Winow.
> 
> consider name the function as PreventWindowFromPinning or DisableWindowPinning

Done.

[jianli, 2013-08-20 18:37:17]

Please explain in the description why we can't implement the support to pin the
panel/hangout window on the taskbar, instead of repeating the bug description.
It is because launching chrome executable with extension app_id (in this case,
hangout id), will launch chrome browser with Hangout options page, instead of
the chat window.

Please ask Ben or Sky to review the UI related changes.

[zhchbin, 2013-08-21 00:39:50]

@sky, PTAL.

[sky, 2013-08-21 01:00:31]

From your description all of the issues you raise sound like they could be
fixed. Is there a reason we don't want to fix them?

[zhchbin, 2013-08-21 01:06:18]

On 2013/08/21 01:00:31, sky wrote:
> From your description all of the issues you raise sound like they could be
> fixed. Is there a reason we don't want to fix them?

Do you mean: Why we can't implement the support (via set the relaunch data) to
pin the panel window on the taskbar?

It is because launching chrome executable with extension app_id (in this case,
hangout id), will launch chrome browser with Hangout options page, instead of
the chat window. @jianli had helped me explain it.

[sky, 2013-08-21 14:47:02]

On Tue, Aug 20, 2013 at 6:06 PM,  <zhchbin@gmail.com> wrote:
> On 2013/08/21 01:00:31, sky wrote:
>>
>>  From your description all of the issues you raise sound like they could
>> be
>> fixed. Is there a reason we don't want to fix them?
>
>
> Do you mean: Why we can't implement the support (via set the relaunch data)
> to
> pin the panel window on the taskbar?
>

Yes.

> It is because launching chrome executable with extension app_id (in this
> case,
> hangout id), will launch chrome browser with Hangout options page, instead
> of
> the chat window. @jianli had helped me explain it.

Why can't it be changed to do the right thing?

  -Scott

>
> https://codereview.chromium.org/23146009/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[zhchbin, 2013-08-21 16:16:13]

> > It is because launching chrome executable with extension app_id (in this
> > case,
> > hangout id), will launch chrome browser with Hangout options page, instead
> > of
> > the chat window. @jianli had helped me explain it.
> 
> Why can't it be changed to do the right thing?
> 
>   -Scott

What do you mean by the "right thing"? Open a panel window? Note that panel
windows are created and used by the extensions. And please take a look at this
issue description. Currently pin a panel window to the task bar and click when
Chrome is closed will open a new Chrome window. I think the user is expecting a
new panel window instead of a Chrome Window. But these panel windows are created
by extensions. Can we launch an extension like other native program? From my
point of view the answer is not. What't more, if we use the extension id to
launch with chrome, as @jianli's comment, it will launch chrome browser with
options page, instead of the chat window.

[jianli, 2013-08-21 17:44:57]

The problem is that we do not currently support launching a panel (Hangout
chat list panel in this case) via the command line. Calling chrome
executable with app id launches the extension and the extension could then
launch the panel at later time. For Hangout extension, the chat list panel
will only be launched when the user clicks on the icon.

Ideally we should fix the underlying problem by supporting pinning a panel
to the taskbar, as Scott pointed out. But given that this could take quite
some time to figure out how to do this and also coordinate with Hangout
extension to make the change, I think removing the pinning capability might
help if the current pinning behavior causes the confusion to users.


On Wed, Aug 21, 2013 at 9:16 AM, <zhchbin@gmail.com> wrote:

> > It is because launching chrome executable with extension app_id (in this
>> > case,
>> > hangout id), will launch chrome browser with Hangout options page,
>> instead
>> > of
>> > the chat window. @jianli had helped me explain it.
>>
>
>  Why can't it be changed to do the right thing?
>>
>
>     -Scott
>>
>
> What do you mean by the "right thing"? Open a panel window? Note that panel
> windows are created and used by the extensions. And please take a look at
> this
> issue description. Currently pin a panel window to the task bar and click
> when
> Chrome is closed will open a new Chrome window. I think the user is
> expecting a
> new panel window instead of a Chrome Window. But these panel windows are
> created
> by extensions. Can we launch an extension like other native program? From
> my
> point of view the answer is not. What't more, if we use the extension id to
> launch with chrome, as @jianli's comment, it will launch chrome browser
> with
>
> options page, instead of the chat window.
>
>
https://codereview.chromium.**org/23146009/<https://codereview.chromium.org/2...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sky, 2013-08-21 22:21:37]

Fair enough, LGTM

[commit-bot: I haz the power, 2013-08-22 00:19:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zhchbin@gmail.com/23146009/5001

[commit-bot: I haz the power, 2013-08-22 08:17:38]

Change committed as 218949