Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 23146007: Implement setter/getter for PaintInfo::outlineObjects. (Closed)

Created:
7 years, 4 months ago by Savago-old
Modified:
7 years, 4 months ago
Reviewers:
eseidel
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Implement setter/getter for PaintInfo::outlineObjects. BUG=266575 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156164

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M Source/core/rendering/InlineFlowBox.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/rendering/PaintInfo.h View 3 chunks +5 lines, -2 lines 2 comments Download
M Source/core/rendering/RenderLineBoxList.cpp View 2 chunks +4 lines, -4 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Savago-old
7 years, 4 months ago (2013-08-15 19:06:20 UTC) #1
eseidel
lgtm https://codereview.chromium.org/23146007/diff/1/Source/core/rendering/PaintInfo.h File Source/core/rendering/PaintInfo.h (right): https://codereview.chromium.org/23146007/diff/1/Source/core/rendering/PaintInfo.h#newcode107 Source/core/rendering/PaintInfo.h:107: void setOutlineObjects(ListHashSet<RenderInline*>* objects) { m_outlineObjects = objects; } ...
7 years, 4 months ago (2013-08-15 19:36:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a.cavalcanti@partner.samsung.com/23146007/1
7 years, 4 months ago (2013-08-15 19:36:52 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-15 20:00:01 UTC) #4
Message was sent while issue was closed.
Change committed as 156164

Powered by Google App Engine
This is Rietveld 408576698