IFrame Scrollbar needs reconstruction.

IFrame Scrollbar needs reconstruction.

IFrame Scrollbar needs reconstruction. In the updateWidgetGeometry set
frameview needs layout if frameview scrollbars needsreconstruction.

BUG=492785
Committed: https://crrev.com/5dc5867ab6200abb2f02392a16267ecec62d676e
Cr-Commit-Position: refs/heads/master@{#418837}

[MuVen, 2016-09-06 09:55:51]

Description was changed from

==========
done


done


done


done

BUG=
==========

to

==========
FrameView Scrollbar needs reconstruction.

FrameView Scrollbar needs reconstruction, when a style rule is inserted, on
updateStyleAndLayoutIfNeededRecursiveInternal, updateScrollbars if scrollbars
needsForReconstruction.

BUG=492785
==========

[MuVen, 2016-09-06 10:01:19]

Patchset #1 (id:1) has been deleted

[MuVen, 2016-09-06 10:04:08]

Description was changed from

==========
FrameView Scrollbar needs reconstruction.

FrameView Scrollbar needs reconstruction, when a style rule is inserted, on
updateStyleAndLayoutIfNeededRecursiveInternal, updateScrollbars if scrollbars
needsForReconstruction.

BUG=492785
==========

to

==========
FrameView Scrollbar needs reconstruction.

FrameView Scrollbar needs reconstruction, when a style rule is inserted
on updateStyleAndLayoutIfNeededRecursiveInternal, updateScrollbars if 
scrollbars needsForReconstruction.


BUG=492785
==========

[MuVen, 2016-09-06 10:05:32]

sataya.m@samsung.com changed reviewers:
+ majidvp@chromium.org, skobes@chromium.org

[MuVen, 2016-09-06 10:05:33]

PATL.

[MuVen, 2016-09-06 10:05:37]

The CQ bit was checked by sataya.m@samsung.com

[commit-bot: I haz the power, 2016-09-06 10:05:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 10:05:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 10:05:53]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[MuVen, 2016-09-06 10:06:26]

The CQ bit was checked by sataya.m@samsung.com to run a CQ dry run

[MuVen, 2016-09-06 10:06:41]

The CQ bit was unchecked by sataya.m@samsung.com

[commit-bot: I haz the power, 2016-09-06 10:06:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[MuVen, 2016-09-06 10:08:07]

The CQ bit was checked by sataya.m@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 10:08:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 11:43:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 11:43:05]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[skobes, 2016-09-06 17:39:20]

https://codereview.chromium.org/2314593003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/2314593003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.cpp:2768:
updateScrollbarsIfNeeded();
FrameView::layout calls updateScrollbarsIfNeeded.  Why do we need to call it
here as well?

[MuVen, 2016-09-07 14:50:17]

https://codereview.chromium.org/2314593003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/2314593003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.cpp:2768:
updateScrollbarsIfNeeded();
as this is a recursively calls for all the frameviews present in the mainframe;
so for each frameview we need to call updatescrollbarsifneeded which checks for
needsreconstruction, based on that it will update the scrollbars.

[skobes, 2016-09-07 19:04:38]

https://codereview.chromium.org/2314593003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/2314593003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.cpp:2768:
updateScrollbarsIfNeeded();
On 2016/09/07 14:50:17, MuVen wrote:
> as this is a recursively calls for all the frameviews present in the
mainframe;
> so for each frameview we need to call updatescrollbarsifneeded which checks
for
> needsreconstruction, based on that it will update the scrollbars.

But layout is also recursive.  Scrollbars changing between native and custom
should invalidate layout.

[MuVen, 2016-09-08 06:55:10]

The CQ bit was checked by sataya.m@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 06:55:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[MuVen, 2016-09-08 07:49:42]

Description was changed from

==========
FrameView Scrollbar needs reconstruction.

FrameView Scrollbar needs reconstruction, when a style rule is inserted
on updateStyleAndLayoutIfNeededRecursiveInternal, updateScrollbars if 
scrollbars needsForReconstruction.


BUG=492785
==========

to

==========
IFrame Scrollbar needs reconstruction.

IFrame Scrollbar needs reconstruction. In the updateWidgetGeometry set
frameview needs layout if frameview scrollbars needsreconstruction.

BUG=492785
==========

[MuVen, 2016-09-08 07:58:28]

PTAL. After debugging a bit further it seems this is the right place to fix the
issue.

Please let me know your comments on this.

[commit-bot: I haz the power, 2016-09-08 08:35:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 08:35:12]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[skobes, 2016-09-08 18:11:07]

lgtm

[MuVen, 2016-09-15 10:17:43]

The CQ bit was checked by sataya.m@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 10:17:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[MuVen, 2016-09-15 10:19:44]

The CQ bit was unchecked by sataya.m@samsung.com

[MuVen, 2016-09-15 11:44:06]

The CQ bit was checked by sataya.m@samsung.com

[MuVen, 2016-09-15 11:44:06]

The patchset sent to the CQ was uploaded after l-g-t-m from skobes@chromium.org
Link to the patchset: https://codereview.chromium.org/2314593003/#ps60001
(title: "added test exceptions")

[commit-bot: I haz the power, 2016-09-15 11:44:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 11:48:51]

Description was changed from

==========
IFrame Scrollbar needs reconstruction.

IFrame Scrollbar needs reconstruction. In the updateWidgetGeometry set
frameview needs layout if frameview scrollbars needsreconstruction.

BUG=492785
==========

to

==========
IFrame Scrollbar needs reconstruction.

IFrame Scrollbar needs reconstruction. In the updateWidgetGeometry set
frameview needs layout if frameview scrollbars needsreconstruction.

BUG=492785
==========

[commit-bot: I haz the power, 2016-09-15 11:48:54]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-09-15 11:51:01]

Description was changed from

==========
IFrame Scrollbar needs reconstruction.

IFrame Scrollbar needs reconstruction. In the updateWidgetGeometry set
frameview needs layout if frameview scrollbars needsreconstruction.

BUG=492785
==========

to

==========
IFrame Scrollbar needs reconstruction.

IFrame Scrollbar needs reconstruction. In the updateWidgetGeometry set
frameview needs layout if frameview scrollbars needsreconstruction.

BUG=492785

Committed: https://crrev.com/5dc5867ab6200abb2f02392a16267ecec62d676e
Cr-Commit-Position: refs/heads/master@{#418837}
==========

[commit-bot: I haz the power, 2016-09-15 11:51:02]

Patchset 3 (id:??) landed as
https://crrev.com/5dc5867ab6200abb2f02392a16267ecec62d676e
Cr-Commit-Position: refs/heads/master@{#418837}

[jbroman, 2016-09-15 14:25:26]

A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/2338413005/ by jbroman@chromium.org.

The reason for reverting is:
virtual/rootlayerscrolls/scrollbars/custom-scrollbar-reconstruction-on-inserting-style-sheet.html
fails reliably on Win 10.

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/1....

[jbroman, 2016-09-15 14:26:07]

On 2016/09/15 at 14:25:26, jbroman wrote:
> A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/2338413005/ by jbroman@chromium.org.
> 
> The reason for reverting is:
virtual/rootlayerscrolls/scrollbars/custom-scrollbar-reconstruction-on-inserting-style-sheet.html
fails reliably on Win 10.
> 
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/1....

On second thought, I think I can just expand the expectation in this CL to
include Win10.

[jbroman, 2016-09-15 14:28:46]

On 2016/09/15 at 14:26:07, jbroman wrote:
> On 2016/09/15 at 14:25:26, jbroman wrote:
> > A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/2338413005/ by jbroman@chromium.org.
> > 
> > The reason for reverting is:
virtual/rootlayerscrolls/scrollbars/custom-scrollbar-reconstruction-on-inserting-style-sheet.html
fails reliably on Win 10.
> > 
> >
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/1....
> 
> On second thought, I think I can just expand the expectation in this CL to
include Win10.

That CL is https://codereview.chromium.org/2347623002.