Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2314573002: Don't expose webshare from the browser when the origin trial disables it. (Closed)

Created:
4 years, 3 months ago by Sam McNally
Modified:
4 years, 2 months ago
CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't expose webshare from the browser when the origin trial disables it. BUG=645004 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/0285a44ea8769e4a6ae7b1a70b663b474055b4e8 Cr-Commit-Position: refs/heads/master@{#422983}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -2 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/WebShareTest.java View 1 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 3 chunks +15 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webshare/NavigatorShare.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp View 1 4 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
Sam McNally
4 years, 3 months ago (2016-09-08 10:02:05 UTC) #9
jochen (gone - plz use gerrit)
why do we remove it instead of not adding it in the first place? Can ...
4 years, 3 months ago (2016-09-08 12:41:07 UTC) #10
Sam McNally
On 2016/09/08 12:41:07, jochen (slow) wrote: > why do we remove it instead of not ...
4 years, 2 months ago (2016-10-04 02:42:01 UTC) #13
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-10-04 14:49:16 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314573002/20001
4 years, 2 months ago (2016-10-04 22:55:51 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 23:04:16 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 23:06:54 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0285a44ea8769e4a6ae7b1a70b663b474055b4e8
Cr-Commit-Position: refs/heads/master@{#422983}

Powered by Google App Engine
This is Rietveld 408576698