Store the ScopeInfo in WithContexts

Store the ScopeInfo in WithContexts

This will allow for chaining ScopeInfos together to form the same chains
as contexts chains currently do.

BUG=v8:5215
R=mstarzinger@chromium.org,marja@chromium.org,bmeurer@chromium.org,rmcilroy@chromium.org

Committed: https://crrev.com/77c4ba0767477a8021902c262c60d8a926747c38
Cr-Commit-Position: refs/heads/master@{#39192}

[jochen (gone - plz use gerrit), 2016-09-05 10:55:47]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-05 10:55:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-09-05 10:56:15]

ptal

Marja: ast
Ross: interpreter
Benedikt: debug/
Michael: rest

[rmcilroy, 2016-09-05 11:07:01]

interpreter/ lgtm

[commit-bot: I haz the power, 2016-09-05 11:23:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-05 11:23:18]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-09-05 11:47:05]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-05 11:47:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-09-05 11:50:08]

(I ported over the comments from the catch scope CL and addressed them here as
well)

[Michael Starzinger, 2016-09-05 12:10:39]

LGTM, just nits.

https://codereview.chromium.org/2314483002/diff/20001/src/compiler/js-create-...
File src/compiler/js-create-lowering.cc (right):

https://codereview.chromium.org/2314483002/diff/20001/src/compiler/js-create-...
src/compiler/js-create-lowering.cc:827: AllocationBuilder aa(jsgraph(), effect,
control);
nit: Empty newline before the first AllocationBuilder for readability.

https://codereview.chromium.org/2314483002/diff/20001/src/compiler/js-generic...
File src/compiler/js-generic-lowering.cc (right):

https://codereview.chromium.org/2314483002/diff/20001/src/compiler/js-generic...
src/compiler/js-generic-lowering.cc:52: REPLACE_RUNTIME_CALL(JSConvertReceiver,
Runtime::kConvertReceiver)
suggestion: I know this is not part of your change, but for bonus points we
could make LowerJSConvertReceiver explicit as well. The second-order macro here
doesn't seem to be useful anymore. Or just ignore this comment, up to you. :)

https://codereview.chromium.org/2314483002/diff/20001/src/factory.cc
File src/factory.cc (right):

https://codereview.chromium.org/2314483002/diff/20001/src/factory.cc#newcode843
src/factory.cc:843: scope_info, extension.is_null() ?
Handle<Object>::cast(the_hole_value())
question: Probably doesn't matter much, but the old code used to store
"undefined" when "extension.is_null", the new code switches to "the_hole". Is
this intentional? Does it matter?

[commit-bot: I haz the power, 2016-09-05 12:15:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-05 12:15:04]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-09-05 12:45:18]

all comments addressed

[Benedikt Meurer, 2016-09-05 12:48:00]

LGTM (stampf)

[marja, 2016-09-06 08:01:05]

ast lgtm

[jochen (gone - plz use gerrit), 2016-09-06 08:01:28]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-09-06 08:01:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2314483002/#ps40001
(title: "updates")

[commit-bot: I haz the power, 2016-09-06 08:01:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 08:27:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-06 08:27:57]

Description was changed from

==========
Store the ScopeInfo in WithContexts

This will allow for chaining ScopeInfos together to form the same chains
as contexts chains currently do.

BUG=v8:5215
R=mstarzinger@chromium.org,marja@chromium.org,bmeurer@chromium.org,rmcilroy@c...
==========

to

==========
Store the ScopeInfo in WithContexts

This will allow for chaining ScopeInfos together to form the same chains
as contexts chains currently do.

BUG=v8:5215
R=mstarzinger@chromium.org,marja@chromium.org,bmeurer@chromium.org,rmcilroy@c...

Committed: https://crrev.com/77c4ba0767477a8021902c262c60d8a926747c38
Cr-Commit-Position: refs/heads/master@{#39192}
==========

[commit-bot: I haz the power, 2016-09-06 08:27:58]

Patchset 3 (id:??) landed as
https://crrev.com/77c4ba0767477a8021902c262c60d8a926747c38
Cr-Commit-Position: refs/heads/master@{#39192}