Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 231443002: Improve reproducibility of test runs. (Closed)

Created:
6 years, 8 months ago by Benedikt Meurer
Modified:
6 years, 8 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
git@github.com:v8/v8.git@master
Visibility:
Public.

Description

Improve reproducibility of test runs. Add random seed to run-tests.py, using either a user supplied value or a random number generated by random.SystemRandom(). This same random seed is passed to all test cases, making sure that we can easily reproduce test failures that depend on random numbers (i.e. bugs related to our handwritten ASLR). Also fix all uses of rand() to make use of our RNG class instead. R=machenbach@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20637

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -13 lines) Patch
M test/cctest/test-strtod.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M test/cctest/test-types.cc View 5 chunks +8 lines, -5 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +5 lines, -1 line 0 comments Download
M tools/run-tests.py View 1 4 chunks +8 lines, -1 line 0 comments Download
M tools/testrunner/local/execution.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/testrunner/objects/context.py View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Benedikt Meurer
PTAL
6 years, 8 months ago (2014-04-09 18:13:38 UTC) #1
Michael Achenbach
lgtm
6 years, 8 months ago (2014-04-10 07:18:06 UTC) #2
Michael Achenbach
https://codereview.chromium.org/231443002/diff/1/tools/run-tests.py File tools/run-tests.py (right): https://codereview.chromium.org/231443002/diff/1/tools/run-tests.py#newcode257 tools/run-tests.py:257: options.random_seed = random.SystemRandom().randint(-2147483647, 2147483647) -...48?
6 years, 8 months ago (2014-04-10 07:18:14 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/231443002/diff/1/tools/run-tests.py File tools/run-tests.py (right): https://codereview.chromium.org/231443002/diff/1/tools/run-tests.py#newcode257 tools/run-tests.py:257: options.random_seed = random.SystemRandom().randint(-2147483647, 2147483647) On 2014/04/10 07:18:14, Michael Achenbach ...
6 years, 8 months ago (2014-04-10 07:25:36 UTC) #4
Benedikt Meurer
6 years, 8 months ago (2014-04-10 07:26:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r20637 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698