Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 2314423005: [gn] Switch noi18n bots to gn (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, petermarshall
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Switch noi18n bots to gn BUG=chromium:474921 NOTRY=true TBR=jochen@chromium.org Committed: https://crrev.com/4266d33e76c673d828645ea447f50e3261ae65f6 Cr-Commit-Position: refs/heads/master@{#39303}

Patch Set 1 #

Patch Set 2 : Fix flag for gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M infra/mb/mb_config.pyl View 1 7 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Michael Achenbach
PTAL Comparison: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%20debug/builds/9576/steps/compare%20build%20flags%20%28fyi%29/logs/stdio Nothing unusual...
4 years, 3 months ago (2016-09-09 08:48:25 UTC) #3
Michael Achenbach
> Nothing unusual... ok - nothing unusual except the isolate failures on the trybot ;). ...
4 years, 3 months ago (2016-09-09 08:49:16 UTC) #4
Michael Achenbach
PTAL at patch 2. The data file flag has a different name in gn: https://cs.chromium.org/chromium/src/third_party/icu/config.gni?l=15
4 years, 3 months ago (2016-09-09 08:52:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314423005/20001
4 years, 3 months ago (2016-09-09 09:13:37 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-09 09:15:38 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 09:16:05 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4266d33e76c673d828645ea447f50e3261ae65f6
Cr-Commit-Position: refs/heads/master@{#39303}

Powered by Google App Engine
This is Rietveld 408576698