Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 2314423003: ozone: Switch some DRM-related warnings to VLOG(1). (Closed)

Created:
4 years, 3 months ago by Daniel Erat
Modified:
4 years, 3 months ago
Reviewers:
dnicoara
CC:
chromium-reviews, kalyank, piman+watch_chromium.org, ozone-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: Switch some DRM-related warnings to VLOG(1). Avoid logging "Unable to get cursor width capability: Invalid argument" and "Could not initialize DRM device" warnings, as these are expected conditions on some systems. BUG=644796 Committed: https://crrev.com/38ca32d4cedc600a047bb34ff5f556ad491779fa Cr-Commit-Position: refs/heads/master@{#417048}

Patch Set 1 #

Patch Set 2 : use VPLOG(1) for cursor messages #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M ui/ozone/platform/drm/common/drm_util.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_device_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Daniel Erat
4 years, 3 months ago (2016-09-07 20:24:40 UTC) #2
dnicoara
lgtm ... nit: Could we use VPLOG(1) to capture the cause as well?
4 years, 3 months ago (2016-09-07 20:27:48 UTC) #5
Daniel Erat
On 2016/09/07 20:27:48, dnicoara wrote: > lgtm ... nit: Could we use VPLOG(1) to capture ...
4 years, 3 months ago (2016-09-07 20:33:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314423003/20001
4 years, 3 months ago (2016-09-07 20:35:44 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-07 21:39:48 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 21:42:32 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/38ca32d4cedc600a047bb34ff5f556ad491779fa
Cr-Commit-Position: refs/heads/master@{#417048}

Powered by Google App Engine
This is Rietveld 408576698