Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 2314403008: Remove PrintWriter and PrintStringWriter from java_core. (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove PrintWriter and PrintStringWriter from java_core. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/6bee780067d3c84bfbc387720a26b0eabe7c2357

Patch Set 1 #

Patch Set 2 : remove _printf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -247 lines) Patch
M pkg/analyzer/lib/src/dart/ast/ast.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/utilities.dart View 55 chunks +173 lines, -174 lines 0 comments Download
M pkg/analyzer/lib/src/generated/java_core.dart View 1 2 chunks +0 lines, -66 lines 0 comments Download
M pkg/analyzer/test/src/dart/ast/utilities_test.dart View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 3 months ago (2016-09-09 16:39:39 UTC) #1
Brian Wilkerson
lgtm
4 years, 3 months ago (2016-09-09 17:55:02 UTC) #2
scheglov
4 years, 3 months ago (2016-09-09 18:32:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6bee780067d3c84bfbc387720a26b0eabe7c2357 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698