Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2314403006: Add back initialization of |dns_resolution_end_time_| in QuicStreamFactory::Job (Closed)

Created:
4 years, 3 months ago by xunjieli
Modified:
4 years, 3 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add back initialization of |dns_resolution_end_time_| in QuicStreamFactory::Job |dns_resolution_end_time_| is still used in other histograms (e.g. Net.QuicServerInfo.DiskCacheWaitForDataReadyTime and Net.QuicSession.HostResolution.HandshakeConfirmedTime). The initialization is removed in crrev.com/2256803002. This CL adds it back to maintain correctness of the remaining histograms which are still using this field. R=zhongyi@chromium.org BUG=629384, 637051 Committed: https://crrev.com/c6f081483992e01bc1ce6f24842911569892b14d Cr-Commit-Position: refs/heads/master@{#417355}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M net/quic/chromium/quic_stream_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
xunjieli
Cherie, PTAL.
4 years, 3 months ago (2016-09-08 17:46:14 UTC) #3
Zhongyi Shi
lgtm! Thanks for fixing this.
4 years, 3 months ago (2016-09-08 17:50:54 UTC) #4
xunjieli
On 2016/09/08 17:50:54, Zhongyi Shi wrote: > lgtm! Thanks for fixing this. np. I was ...
4 years, 3 months ago (2016-09-08 17:57:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314403006/1
4 years, 3 months ago (2016-09-08 17:57:45 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 19:00:38 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 19:04:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c6f081483992e01bc1ce6f24842911569892b14d
Cr-Commit-Position: refs/heads/master@{#417355}

Powered by Google App Engine
This is Rietveld 408576698