Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1282)

Unified Diff: content/renderer/media/media_recorder_handler.cc

Issue 2314403003: media_recorder_handler: Changed deprecated ScopedVector to std::vector (Closed)
Patch Set: media_recorder_handler: Replaced raw pointer with std::unique_ptr Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/media_recorder_handler.cc
diff --git a/content/renderer/media/media_recorder_handler.cc b/content/renderer/media/media_recorder_handler.cc
index ce59ce42a4ecf1baf89f21bcf150aa896648dec3..370bee2f9a959a89324b38eddc7af2e26dbbfe55 100644
--- a/content/renderer/media/media_recorder_handler.cc
+++ b/content/renderer/media/media_recorder_handler.cc
@@ -199,7 +199,7 @@ bool MediaRecorderHandler::start(int timeslice) {
media::BindToCurrentLoop(base::Bind(
&MediaRecorderHandler::OnEncodedVideo, weak_factory_.GetWeakPtr()));
- video_recorders_.push_back(new VideoTrackRecorder(
+ video_recorders_.emplace_back(new VideoTrackRecorder(
codec_id_, video_track, on_encoded_video_cb, video_bits_per_second_));
}
@@ -217,7 +217,7 @@ bool MediaRecorderHandler::start(int timeslice) {
media::BindToCurrentLoop(base::Bind(
&MediaRecorderHandler::OnEncodedAudio, weak_factory_.GetWeakPtr()));
- audio_recorders_.push_back(new AudioTrackRecorder(
+ audio_recorders_.emplace_back(new AudioTrackRecorder(
audio_track, on_encoded_audio_cb, audio_bits_per_second_));
}
@@ -240,9 +240,9 @@ void MediaRecorderHandler::pause() {
DCHECK(main_render_thread_checker_.CalledOnValidThread());
DCHECK(recording_);
recording_ = false;
- for (auto* video_recorder : video_recorders_)
+ for (auto& video_recorder : video_recorders_)
mcasas 2016/09/08 16:21:08 const auto&, here and elsewhere.
video_recorder->Pause();
- for (auto* audio_recorder : audio_recorders_)
+ for (auto& audio_recorder : audio_recorders_)
audio_recorder->Pause();
webm_muxer_->Pause();
}
@@ -251,9 +251,9 @@ void MediaRecorderHandler::resume() {
DCHECK(main_render_thread_checker_.CalledOnValidThread());
DCHECK(!recording_);
recording_ = true;
- for (auto* video_recorder : video_recorders_)
+ for (auto& video_recorder : video_recorders_)
video_recorder->Resume();
- for (auto* audio_recorder : audio_recorders_)
+ for (auto& audio_recorder : audio_recorders_)
audio_recorder->Resume();
webm_muxer_->Resume();
}
@@ -298,20 +298,20 @@ void MediaRecorderHandler::WriteData(base::StringPiece data) {
void MediaRecorderHandler::OnVideoFrameForTesting(
const scoped_refptr<media::VideoFrame>& frame,
const TimeTicks& timestamp) {
- for (auto* recorder : video_recorders_)
+ for (auto& recorder : video_recorders_)
recorder->OnVideoFrameForTesting(frame, timestamp);
}
void MediaRecorderHandler::OnAudioBusForTesting(
const media::AudioBus& audio_bus,
const base::TimeTicks& timestamp) {
- for (auto* recorder : audio_recorders_)
+ for (auto& recorder : audio_recorders_)
recorder->OnData(audio_bus, timestamp);
}
void MediaRecorderHandler::SetAudioFormatForTesting(
const media::AudioParameters& params) {
- for (auto* recorder : audio_recorders_)
+ for (auto& recorder : audio_recorders_)
recorder->OnSetFormat(params);
}

Powered by Google App Engine
This is Rietveld 408576698