|
|
Created:
4 years, 3 months ago by xianglu Modified:
4 years, 3 months ago Reviewers:
mcasas CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionmedia_recorder_handler: Changed deprecated ScopedVector to std::vector, and introduced emplace_back().
This CL is a code refactoring, no new code added.
R=mcasas@chromium.org
BUG=643714
TEST=all content_browsertests passing.
Committed: https://crrev.com/8d0beae46fa913e6cf8bae965c95d2a15707d34f
Cr-Commit-Position: refs/heads/master@{#417362}
Patch Set 1 #
Total comments: 1
Patch Set 2 : media_recorder_handler: Replaced raw pointer with std::unique_ptr #
Total comments: 2
Patch Set 3 : media_recorder_handler.cc: Iterate using const auto #
Messages
Total messages: 22 (10 generated)
PTAL
On 2016/09/07 22:02:24, xianglu wrote: > PTAL lgtm f the bots are happy Also, please consider adding some hint of the code location in the CL description, e.g. "MediaRecorder: change deprecated..." and indicate how you tested this change, if relevant; in this case you could indicate in the CL body: "This CL is a code refactoring, no new code added" and then, after to the BUG line, add "TEST=all unittests and content_browsertests passing."
Description was changed from ========== Changed deprecated ScopedVector to std::vector R=mcasas@chromium.org BUG=643714 ========== to ========== media_recorder_handler: Changed deprecated ScopedVector to std::vector, and introduced emplace_back(). This CL is a code refactoring, no new code added. R=mcasas@chromium.org BUG=643714 TEST=all content_browsertests passing. ==========
https://codereview.chromium.org/2314403003/diff/1/content/renderer/media/medi... File content/renderer/media/media_recorder_handler.h (right): https://codereview.chromium.org/2314403003/diff/1/content/renderer/media/medi... content/renderer/media/media_recorder_handler.h:108: std::vector<AudioTrackRecorder*> audio_recorders_; Oops, haven't noticed this. You have to use std::unique_ptr.
On 2016/09/07 23:04:40, mcasas wrote: > https://codereview.chromium.org/2314403003/diff/1/content/renderer/media/medi... > File content/renderer/media/media_recorder_handler.h (right): > > https://codereview.chromium.org/2314403003/diff/1/content/renderer/media/medi... > content/renderer/media/media_recorder_handler.h:108: > std::vector<AudioTrackRecorder*> audio_recorders_; > Oops, haven't noticed this. > You have to use std::unique_ptr. Done.
The CQ bit was checked by xianglu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mcasas@chromium.org Link to the patchset: https://codereview.chromium.org/2314403003/#ps20001 (title: "media_recorder_handler: Replaced raw pointer with std::unique_ptr")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
https://codereview.chromium.org/2314403003/diff/20001/content/renderer/media/... File content/renderer/media/media_recorder_handler.cc (right): https://codereview.chromium.org/2314403003/diff/20001/content/renderer/media/... content/renderer/media/media_recorder_handler.cc:243: for (auto& video_recorder : video_recorders_) const auto&, here and elsewhere. https://codereview.chromium.org/2314403003/diff/20001/content/renderer/media/... File content/renderer/media/media_recorder_handler.h (right): https://codereview.chromium.org/2314403003/diff/20001/content/renderer/media/... content/renderer/media/media_recorder_handler.h:12: #include "base/memory/scoped_vector.h" Not needed.
On 2016/09/08 16:21:09, mcasas wrote: > https://codereview.chromium.org/2314403003/diff/20001/content/renderer/media/... > File content/renderer/media/media_recorder_handler.cc (right): > > https://codereview.chromium.org/2314403003/diff/20001/content/renderer/media/... > content/renderer/media/media_recorder_handler.cc:243: for (auto& video_recorder > : video_recorders_) > const auto&, here and elsewhere. > > https://codereview.chromium.org/2314403003/diff/20001/content/renderer/media/... > File content/renderer/media/media_recorder_handler.h (right): > > https://codereview.chromium.org/2314403003/diff/20001/content/renderer/media/... > content/renderer/media/media_recorder_handler.h:12: #include > "base/memory/scoped_vector.h" > Not needed. Changed.
On 2016/09/08 17:12:54, xianglu wrote: > On 2016/09/08 16:21:09, mcasas wrote: > > > https://codereview.chromium.org/2314403003/diff/20001/content/renderer/media/... > > File content/renderer/media/media_recorder_handler.cc (right): > > > > > https://codereview.chromium.org/2314403003/diff/20001/content/renderer/media/... > > content/renderer/media/media_recorder_handler.cc:243: for (auto& > video_recorder > > : video_recorders_) > > const auto&, here and elsewhere. > > > > > https://codereview.chromium.org/2314403003/diff/20001/content/renderer/media/... > > File content/renderer/media/media_recorder_handler.h (right): > > > > > https://codereview.chromium.org/2314403003/diff/20001/content/renderer/media/... > > content/renderer/media/media_recorder_handler.h:12: #include > > "base/memory/scoped_vector.h" > > Not needed. > > Changed. lgtm. bots please
The CQ bit was checked by xianglu@chromium.org
The CQ bit was unchecked by xianglu@chromium.org
The CQ bit was checked by xianglu@chromium.org
The CQ bit was unchecked by xianglu@chromium.org
The CQ bit was checked by xianglu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== media_recorder_handler: Changed deprecated ScopedVector to std::vector, and introduced emplace_back(). This CL is a code refactoring, no new code added. R=mcasas@chromium.org BUG=643714 TEST=all content_browsertests passing. ========== to ========== media_recorder_handler: Changed deprecated ScopedVector to std::vector, and introduced emplace_back(). This CL is a code refactoring, no new code added. R=mcasas@chromium.org BUG=643714 TEST=all content_browsertests passing. Committed: https://crrev.com/8d0beae46fa913e6cf8bae965c95d2a15707d34f Cr-Commit-Position: refs/heads/master@{#417362} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/8d0beae46fa913e6cf8bae965c95d2a15707d34f Cr-Commit-Position: refs/heads/master@{#417362} |