Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2314403003: media_recorder_handler: Changed deprecated ScopedVector to std::vector (Closed)

Created:
4 years, 3 months ago by xianglu
Modified:
4 years, 3 months ago
Reviewers:
mcasas
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media_recorder_handler: Changed deprecated ScopedVector to std::vector, and introduced emplace_back(). This CL is a code refactoring, no new code added. R=mcasas@chromium.org BUG=643714 TEST=all content_browsertests passing. Committed: https://crrev.com/8d0beae46fa913e6cf8bae965c95d2a15707d34f Cr-Commit-Position: refs/heads/master@{#417362}

Patch Set 1 #

Total comments: 1

Patch Set 2 : media_recorder_handler: Replaced raw pointer with std::unique_ptr #

Total comments: 2

Patch Set 3 : media_recorder_handler.cc: Iterate using const auto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M content/renderer/media/media_recorder_handler.h View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M content/renderer/media/media_recorder_handler.cc View 1 2 5 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
xianglu
4 years, 3 months ago (2016-09-07 22:01:45 UTC) #1
xianglu
PTAL
4 years, 3 months ago (2016-09-07 22:02:24 UTC) #2
mcasas
On 2016/09/07 22:02:24, xianglu wrote: > PTAL lgtm f the bots are happy Also, please ...
4 years, 3 months ago (2016-09-07 22:26:54 UTC) #3
mcasas
https://codereview.chromium.org/2314403003/diff/1/content/renderer/media/media_recorder_handler.h File content/renderer/media/media_recorder_handler.h (right): https://codereview.chromium.org/2314403003/diff/1/content/renderer/media/media_recorder_handler.h#newcode108 content/renderer/media/media_recorder_handler.h:108: std::vector<AudioTrackRecorder*> audio_recorders_; Oops, haven't noticed this. You have to ...
4 years, 3 months ago (2016-09-07 23:04:40 UTC) #5
xianglu
On 2016/09/07 23:04:40, mcasas wrote: > https://codereview.chromium.org/2314403003/diff/1/content/renderer/media/media_recorder_handler.h > File content/renderer/media/media_recorder_handler.h (right): > > https://codereview.chromium.org/2314403003/diff/1/content/renderer/media/media_recorder_handler.h#newcode108 > ...
4 years, 3 months ago (2016-09-07 23:26:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314403003/20001
4 years, 3 months ago (2016-09-07 23:48:00 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/65432) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 3 months ago (2016-09-07 23:51:54 UTC) #11
mcasas
https://codereview.chromium.org/2314403003/diff/20001/content/renderer/media/media_recorder_handler.cc File content/renderer/media/media_recorder_handler.cc (right): https://codereview.chromium.org/2314403003/diff/20001/content/renderer/media/media_recorder_handler.cc#newcode243 content/renderer/media/media_recorder_handler.cc:243: for (auto& video_recorder : video_recorders_) const auto&, here and ...
4 years, 3 months ago (2016-09-08 16:21:09 UTC) #12
xianglu
On 2016/09/08 16:21:09, mcasas wrote: > https://codereview.chromium.org/2314403003/diff/20001/content/renderer/media/media_recorder_handler.cc > File content/renderer/media/media_recorder_handler.cc (right): > > https://codereview.chromium.org/2314403003/diff/20001/content/renderer/media/media_recorder_handler.cc#newcode243 > ...
4 years, 3 months ago (2016-09-08 17:12:54 UTC) #13
mcasas
On 2016/09/08 17:12:54, xianglu wrote: > On 2016/09/08 16:21:09, mcasas wrote: > > > https://codereview.chromium.org/2314403003/diff/20001/content/renderer/media/media_recorder_handler.cc ...
4 years, 3 months ago (2016-09-08 17:20:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314403003/40001
4 years, 3 months ago (2016-09-08 18:06:20 UTC) #20
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 19:32:51 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8d0beae46fa913e6cf8bae965c95d2a15707d34f
Cr-Commit-Position: refs/heads/master@{#417362}

Powered by Google App Engine
This is Rietveld 408576698