Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2314393004: Gallery: Leave edit mode on starting print preview. (Closed)

Created:
4 years, 3 months ago by fukino
Modified:
4 years, 3 months ago
Reviewers:
yamaguchi
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gallery: Leave edit mode on starting print preview. If an image is being edited and print button is clicked, we need to leave the editing mode to prevent unwanted images from populating in the print preview. BUG=621485 TEST=manually confirmed following the repro steps. Committed: https://crrev.com/d248394bca77540a9de057cefe28425fff954873 Cr-Commit-Position: refs/heads/master@{#417274}

Patch Set 1 #

Patch Set 2 : Gallery: Leave edit mode on starting print preview. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/file_manager/gallery/js/slide_mode.js View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
fukino
PTAL. Thanks!
4 years, 3 months ago (2016-09-08 08:44:16 UTC) #2
yamaguchi
lgtm
4 years, 3 months ago (2016-09-08 12:40:18 UTC) #3
fukino
Thank you!
4 years, 3 months ago (2016-09-08 12:42:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314393004/20001
4 years, 3 months ago (2016-09-08 12:43:15 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-08 13:43:36 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 13:44:49 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d248394bca77540a9de057cefe28425fff954873
Cr-Commit-Position: refs/heads/master@{#417274}

Powered by Google App Engine
This is Rietveld 408576698