Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2314383002: chromium_android: fix dangerous default value (Closed)

Created:
4 years, 3 months ago by Paweł Hajdan Jr.
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

chromium_android: fix dangerous default value See e.g. http://effbot.org/zone/default-values.htm for more info. The list is mutated inside the method, and the changes persist between invocations. BUG=none Committed: https://chromium.googlesource.com/chromium/tools/build/+/13856309f4dff0281657c5f282c5c99e55096947

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M scripts/slave/recipe_modules/chromium_android/api.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Paweł Hajdan Jr.
4 years, 3 months ago (2016-09-07 11:40:40 UTC) #2
emso
lgtm
4 years, 3 months ago (2016-09-07 11:47:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314383002/1
4 years, 3 months ago (2016-09-07 11:48:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314383002/1
4 years, 3 months ago (2016-09-07 11:49:33 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 11:52:11 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/13856309f4dff0281657...

Powered by Google App Engine
This is Rietveld 408576698