chrome/browser/extensions/extension_creator.cc - Issue 2314363002: extensions: Change ScopedTempDir::path() to GetPath()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_creator.cc

Issue 2314363002: extensions: Change ScopedTempDir::path() to GetPath() (Closed)

Patch Set: rebased Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_creator.cc

diff --git a/chrome/browser/extensions/extension_creator.cc b/chrome/browser/extensions/extension_creator.cc

index f78fdcf1aa83c92fae6982b5681a679d5d081f1a..5255007a76c2212de59fd907c8a73c8a6fd35881 100644

--- a/chrome/browser/extensions/extension_creator.cc

+++ b/chrome/browser/extensions/extension_creator.cc

@@ -321,7 +321,7 @@ bool ExtensionCreator::Run(const base::FilePath& extension_dir,

base::FilePath zip_path;

std::vector<uint8_t> signature;

bool result = false;

- if (CreateZip(extension_dir, temp_dir.path(), &zip_path) &&

+ if (CreateZip(extension_dir, temp_dir.GetPath(), &zip_path) &&

SignZip(zip_path, key_pair.get(), &signature) &&

WriteCRX(zip_path, key_pair.get(), signature, crx_path)) {

result = true;