chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc - Issue 2314363002: extensions: Change ScopedTempDir::path() to GetPath()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc

Issue 2314363002: extensions: Change ScopedTempDir::path() to GetPath() (Closed)

Patch Set: rebased Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/commands/command_service_browsertest.cc ('k') | chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc » ('j') | chrome/browser/extensions/test_extension_dir.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc

diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc b/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc

index 508c7db0c2583325f80475923f7bc6f55bb1992e..9e2a741d401cc0f3345c8454a75c1b8df94b3e3b 100644

--- a/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc

+++ b/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc

@@ -303,11 +303,12 @@ TEST_F(DeveloperPrivateApiUnitTest, DeveloperPrivatePackFunction) {

base::ScopedTempDir temp_dir;

ASSERT_TRUE(temp_dir.CreateUniqueTempDir());

base::FilePath root_path = data_dir().AppendASCII("good_unpacked");

- ASSERT_TRUE(base::CopyDirectory(root_path, temp_dir.path(), true));

+ ASSERT_TRUE(base::CopyDirectory(root_path, temp_dir.GetPath(), true));

- base::FilePath temp_root_path = temp_dir.path().Append(root_path.BaseName());

- base::FilePath crx_path = temp_dir.path().AppendASCII("good_unpacked.crx");

- base::FilePath pem_path = temp_dir.path().AppendASCII("good_unpacked.pem");

+ base::FilePath temp_root_path =

+ temp_dir.GetPath().Append(root_path.BaseName());

+ base::FilePath crx_path = temp_dir.GetPath().AppendASCII("good_unpacked.crx");

+ base::FilePath pem_path = temp_dir.GetPath().AppendASCII("good_unpacked.pem");

EXPECT_FALSE(base::PathExists(crx_path))

<< "crx should not exist before the test is run!";