chrome/browser/extensions/extension_disabled_ui_browsertest.cc - Issue 2314363002: extensions: Change ScopedTempDir::path() to GetPath()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_disabled_ui_browsertest.cc

Issue 2314363002: extensions: Change ScopedTempDir::path() to GetPath() (Closed)

Patch Set: Comment addressed Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_creator_filter_unittest.cc ('k') | chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_disabled_ui_browsertest.cc

diff --git a/chrome/browser/extensions/extension_disabled_ui_browsertest.cc b/chrome/browser/extensions/extension_disabled_ui_browsertest.cc

index 7b4fff1e8a3f93d6e16544a894859adfcf4f876f..0e11967e0d7df31664847d142095106c15fd45b0 100644

--- a/chrome/browser/extensions/extension_disabled_ui_browsertest.cc

+++ b/chrome/browser/extensions/extension_disabled_ui_browsertest.cc

@@ -63,18 +63,15 @@ class ExtensionDisabledGlobalErrorTest : public ExtensionBrowserTest {

const base::FilePath pem_path = test_dir.AppendASCII("permissions.pem");

path_v1_ = PackExtensionWithOptions(

test_dir.AppendASCII("v1"),

- scoped_temp_dir_.path().AppendASCII("permissions1.crx"),

- pem_path,

+ scoped_temp_dir_.GetPath().AppendASCII("permissions1.crx"), pem_path,

base::FilePath());

path_v2_ = PackExtensionWithOptions(

test_dir.AppendASCII("v2"),

- scoped_temp_dir_.path().AppendASCII("permissions2.crx"),

- pem_path,

+ scoped_temp_dir_.GetPath().AppendASCII("permissions2.crx"), pem_path,

base::FilePath());

path_v3_ = PackExtensionWithOptions(

test_dir.AppendASCII("v3"),

- scoped_temp_dir_.path().AppendASCII("permissions3.crx"),

- pem_path,

+ scoped_temp_dir_.GetPath().AppendASCII("permissions3.crx"), pem_path,

base::FilePath());

}

@@ -242,7 +239,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionDisabledGlobalErrorTest,

.AppendASCII("updates.xml"));

interceptor.SetResponseIgnoreQuery(

GURL("http://localhost/autoupdate/v2.crx"),

- scoped_temp_dir_.path().AppendASCII("permissions2.crx"));

+ scoped_temp_dir_.GetPath().AppendASCII("permissions2.crx"));

sync_service->MergeDataAndStartSyncing(

syncer::EXTENSIONS, syncer::SyncDataList(),

@@ -282,7 +279,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionDisabledGlobalErrorTest, RemoteInstall) {

.AppendASCII("updates.xml"));

interceptor.SetResponseIgnoreQuery(

GURL("http://localhost/autoupdate/v2.crx"),

- scoped_temp_dir_.path().AppendASCII("permissions2.crx"));

+ scoped_temp_dir_.GetPath().AppendASCII("permissions2.crx"));

sync_pb::EntitySpecifics specifics;

specifics.mutable_extension()->set_id(extension_id);