extensions: Change ScopedTempDir::path() to GetPath()

extensions/common/file_util_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/file_util.h"
 
 #include <stddef.h>
 
 #include <utility>
 
@@ skipping 50 matching lines @@
 
 typedef testing::Test FileUtilTest;
 
 TEST_F(FileUtilTest, InstallUninstallGarbageCollect) {
   base::ScopedTempDir temp;
   ASSERT_TRUE(temp.CreateUniqueTempDir());
 
   // Create a source extension.
   std::string extension_id("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa");
   std::string version("1.0");
-  base::FilePath src = temp.path().AppendASCII(extension_id);
+  base::FilePath src = temp.GetPath().AppendASCII(extension_id);
   ASSERT_TRUE(base::CreateDirectory(src));
 
   base::FilePath extension_content;
   base::CreateTemporaryFileInDir(src, &extension_content);
   ASSERT_TRUE(base::PathExists(extension_content));
 
   // Create a extensions tree.
-  base::FilePath all_extensions = temp.path().AppendASCII("extensions");
+  base::FilePath all_extensions = temp.GetPath().AppendASCII("extensions");
   ASSERT_TRUE(base::CreateDirectory(all_extensions));
 
   // Install in empty directory. Should create parent directories as needed.
   base::FilePath version_1 =
       file_util::InstallExtension(src, extension_id, version, all_extensions);
   ASSERT_EQ(
       version_1.value(),
       all_extensions.AppendASCII(extension_id).AppendASCII("1.0_0").value());
   ASSERT_TRUE(base::DirectoryExists(version_1));
   ASSERT_TRUE(base::PathExists(version_1.Append(extension_content.BaseName())));
@@ skipping 51 matching lines @@
   scoped_refptr<Extension> extension(file_util::LoadExtension(
       install_dir, Manifest::UNPACKED, Extension::NO_FLAGS, &error));
   ASSERT_FALSE(extension.get() == NULL);
   EXPECT_TRUE(error.empty());
 }
 
 TEST_F(FileUtilTest, CheckIllegalFilenamesNoUnderscores) {
   base::ScopedTempDir temp;
   ASSERT_TRUE(temp.CreateUniqueTempDir());
 
-  base::FilePath src_path = temp.path().AppendASCII("some_dir");
+  base::FilePath src_path = temp.GetPath().AppendASCII("some_dir");
   ASSERT_TRUE(base::CreateDirectory(src_path));
 
   std::string data = "{ \"name\": { \"message\": \"foobar\" } }";
   ASSERT_TRUE(base::WriteFile(
       src_path.AppendASCII("some_file.txt"), data.c_str(), data.length()));
   std::string error;
-  EXPECT_TRUE(file_util::CheckForIllegalFilenames(temp.path(), &error));
+  EXPECT_TRUE(file_util::CheckForIllegalFilenames(temp.GetPath(), &error));
 }
 
 TEST_F(FileUtilTest, CheckIllegalFilenamesOnlyReserved) {
   base::ScopedTempDir temp;
   ASSERT_TRUE(temp.CreateUniqueTempDir());
 
   const base::FilePath::CharType* folders[] = {
       extensions::kLocaleFolder, extensions::kPlatformSpecificFolder};
 
   for (size_t i = 0; i < arraysize(folders); i++) {
-    base::FilePath src_path = temp.path().Append(folders[i]);
+    base::FilePath src_path = temp.GetPath().Append(folders[i]);
     ASSERT_TRUE(base::CreateDirectory(src_path));
   }
 
   std::string error;
-  EXPECT_TRUE(file_util::CheckForIllegalFilenames(temp.path(), &error));
+  EXPECT_TRUE(file_util::CheckForIllegalFilenames(temp.GetPath(), &error));
 }
 
 TEST_F(FileUtilTest, CheckIllegalFilenamesReservedAndIllegal) {
   base::ScopedTempDir temp;
   ASSERT_TRUE(temp.CreateUniqueTempDir());
 
-  base::FilePath src_path = temp.path().Append(extensions::kLocaleFolder);
+  base::FilePath src_path = temp.GetPath().Append(extensions::kLocaleFolder);
   ASSERT_TRUE(base::CreateDirectory(src_path));
 
-  src_path = temp.path().AppendASCII("_some_dir");
+  src_path = temp.GetPath().AppendASCII("_some_dir");
   ASSERT_TRUE(base::CreateDirectory(src_path));
 
   std::string error;
-  EXPECT_FALSE(file_util::CheckForIllegalFilenames(temp.path(), &error));
+  EXPECT_FALSE(file_util::CheckForIllegalFilenames(temp.GetPath(), &error));
 }
 
 // These tests do not work on Windows, because it is illegal to create a
 // file/directory with a Windows reserved name. Because we cannot create a
 // file that will cause the test to fail, let's skip the test.
 #if !defined(OS_WIN)
 TEST_F(FileUtilTest, CheckIllegalFilenamesDirectoryWindowsReserved) {
   base::ScopedTempDir temp;
   ASSERT_TRUE(temp.CreateUniqueTempDir());
 
-  base::FilePath src_path = temp.path().AppendASCII("aux");
+  base::FilePath src_path = temp.GetPath().AppendASCII("aux");
   ASSERT_TRUE(base::CreateDirectory(src_path));
 
   std::string error;
   EXPECT_FALSE(
-      file_util::CheckForWindowsReservedFilenames(temp.path(), &error));
+      file_util::CheckForWindowsReservedFilenames(temp.GetPath(), &error));
 }
 
 TEST_F(FileUtilTest,
        CheckIllegalFilenamesWindowsReservedFilenameWithExtension) {
   base::ScopedTempDir temp;
   ASSERT_TRUE(temp.CreateUniqueTempDir());
 
-  base::FilePath src_path = temp.path().AppendASCII("some_dir");
+  base::FilePath src_path = temp.GetPath().AppendASCII("some_dir");
   ASSERT_TRUE(base::CreateDirectory(src_path));
 
   std::string data = "{ \"name\": { \"message\": \"foobar\" } }";
   ASSERT_TRUE(base::WriteFile(src_path.AppendASCII("lpt1.txt"), data.c_str(),
                               data.length()));
 
   std::string error;
   EXPECT_FALSE(
-      file_util::CheckForWindowsReservedFilenames(temp.path(), &error));
+      file_util::CheckForWindowsReservedFilenames(temp.GetPath(), &error));
 }
 #endif
 
 TEST_F(FileUtilTest, LoadExtensionGivesHelpfullErrorOnMissingManifest) {
   base::FilePath install_dir;
   ASSERT_TRUE(PathService::Get(DIR_TEST_DATA, &install_dir));
   install_dir =
       install_dir.AppendASCII("file_util").AppendASCII("missing_manifest");
 
   std::string error;
@@ skipping 21 matching lines @@
       error.c_str());
 }
 
 TEST_F(FileUtilTest, ValidateThemeUTF8) {
   base::ScopedTempDir temp;
   ASSERT_TRUE(temp.CreateUniqueTempDir());
 
   // "aeo" with accents. Use http://0xcc.net/jsescape/ to decode them.
   std::string non_ascii_file = "\xC3\xA0\xC3\xA8\xC3\xB2.png";
   base::FilePath non_ascii_path =
-      temp.path().Append(base::FilePath::FromUTF8Unsafe(non_ascii_file));
+      temp.GetPath().Append(base::FilePath::FromUTF8Unsafe(non_ascii_file));
   base::WriteFile(non_ascii_path, "", 0);
 
   std::string kManifest = base::StringPrintf(
       "{ \"name\": \"Test\", \"version\": \"1.0\", "
       "  \"theme\": { \"images\": { \"theme_frame\": \"%s\" } }"
       "}",
       non_ascii_file.c_str());
   std::string error;
   scoped_refptr<Extension> extension = LoadExtensionManifest(
-      kManifest, temp.path(), Manifest::UNPACKED, 0, &error);
+      kManifest, temp.GetPath(), Manifest::UNPACKED, 0, &error);
   ASSERT_TRUE(extension.get()) << error;
 
   std::vector<extensions::InstallWarning> warnings;
   EXPECT_TRUE(file_util::ValidateExtension(extension.get(), &error, &warnings))
       << error;
   EXPECT_EQ(0U, warnings.size());
 }
 
 TEST_F(FileUtilTest, BackgroundScriptsMustExist) {
   base::ScopedTempDir temp;
   ASSERT_TRUE(temp.CreateUniqueTempDir());
 
   std::unique_ptr<base::DictionaryValue> value(new base::DictionaryValue());
   value->SetString("name", "test");
   value->SetString("version", "1");
   value->SetInteger("manifest_version", 1);
 
   base::ListValue* scripts = new base::ListValue();
   scripts->AppendString("foo.js");
   value->Set("background.scripts", scripts);
 
   std::string error;
   std::vector<extensions::InstallWarning> warnings;
-  scoped_refptr<Extension> extension =
-      LoadExtensionManifest(*value, temp.path(), Manifest::UNPACKED, 0, &error);
+  scoped_refptr<Extension> extension = LoadExtensionManifest(
+      *value, temp.GetPath(), Manifest::UNPACKED, 0, &error);
   ASSERT_TRUE(extension.get()) << error;
 
   EXPECT_FALSE(
       file_util::ValidateExtension(extension.get(), &error, &warnings));
   EXPECT_EQ(
       l10n_util::GetStringFUTF8(IDS_EXTENSION_LOAD_BACKGROUND_SCRIPT_FAILED,
                                 base::ASCIIToUTF16("foo.js")),
       error);
   EXPECT_EQ(0U, warnings.size());
 
   scripts->Clear();
   scripts->AppendString("http://google.com/foo.js");
 
-  extension =
-      LoadExtensionManifest(*value, temp.path(), Manifest::UNPACKED, 0, &error);
+  extension = LoadExtensionManifest(*value, temp.GetPath(), Manifest::UNPACKED,
+                                    0, &error);
   ASSERT_TRUE(extension.get()) << error;
 
   warnings.clear();
   EXPECT_FALSE(
       file_util::ValidateExtension(extension.get(), &error, &warnings));
   EXPECT_EQ(
       l10n_util::GetStringFUTF8(IDS_EXTENSION_LOAD_BACKGROUND_SCRIPT_FAILED,
                                 base::ASCIIToUTF16("http://google.com/foo.js")),
       error);
   EXPECT_EQ(0U, warnings.size());
@@ skipping 16 matching lines @@
     "vHAI0Llmw7tj7jv17pAkEAz44uXRpjRKtllUIvi5pUENAHwDz+HvdpGH68jpU3hmb\n"
     "uOwrmnQYxaMReFV68Z2w9DcLZn07f7/R9Wn72z89CxwJAFsDoNaDes4h48bX7plct\n"
     "s9ACjmTwcCigZjN2K7AGv7ntCLF3DnV5dK0dTHNaAdD3SbY3jl29Rk2CwiURSX6Ee\n"
     "g==\n"
     "-----END PRIVATE KEY-----\n";
 
 TEST_F(FileUtilTest, FindPrivateKeyFiles) {
   base::ScopedTempDir temp;
   ASSERT_TRUE(temp.CreateUniqueTempDir());
 
-  base::FilePath src_path = temp.path().AppendASCII("some_dir");
+  base::FilePath src_path = temp.GetPath().AppendASCII("some_dir");
   ASSERT_TRUE(base::CreateDirectory(src_path));
 
   ASSERT_TRUE(base::WriteFile(
       src_path.AppendASCII("a_key.pem"), private_key, arraysize(private_key)));
   ASSERT_TRUE(base::WriteFile(src_path.AppendASCII("second_key.pem"),
                               private_key,
                               arraysize(private_key)));
   // Shouldn't find a key with a different extension.
   ASSERT_TRUE(base::WriteFile(src_path.AppendASCII("key.diff_ext"),
                               private_key,
                               arraysize(private_key)));
   // Shouldn't find a key that isn't parsable.
   ASSERT_TRUE(base::WriteFile(src_path.AppendASCII("unparsable_key.pem"),
                               private_key,
                               arraysize(private_key) - 30));
   std::vector<base::FilePath> private_keys =
-      file_util::FindPrivateKeyFiles(temp.path());
+      file_util::FindPrivateKeyFiles(temp.GetPath());
   EXPECT_EQ(2U, private_keys.size());
   EXPECT_THAT(private_keys,
               testing::Contains(src_path.AppendASCII("a_key.pem")));
   EXPECT_THAT(private_keys,
               testing::Contains(src_path.AppendASCII("second_key.pem")));
 }
 
 TEST_F(FileUtilTest, WarnOnPrivateKey) {
   base::ScopedTempDir temp;
   ASSERT_TRUE(temp.CreateUniqueTempDir());
 
-  base::FilePath ext_path = temp.path().AppendASCII("ext_root");
+  base::FilePath ext_path = temp.GetPath().AppendASCII("ext_root");
   ASSERT_TRUE(base::CreateDirectory(ext_path));
 
   const char manifest[] =
       "{\n"
       "  \"name\": \"Test Extension\",\n"
       "  \"version\": \"1.0\",\n"
       "  \"manifest_version\": 2,\n"
       "  \"description\": \"The first extension that I made.\"\n"
       "}\n";
   ASSERT_TRUE(base::WriteFile(
@@ skipping 152 matching lines @@
     base::FilePath actual_path =
         extensions::file_util::ExtensionResourceURLToFilePath(url, root_path);
     EXPECT_EQ(expected_path.value(), actual_path.value()) <<
       " For the path " << url;
   }
   // Remove temp files.
   ASSERT_TRUE(base::DeleteFile(root_path, true));
 }
 
 }  // namespace extensions