Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 2314263002: [Offline Pages] Adds UMA for number of started attempts and for network (Closed)

Created:
4 years, 3 months ago by Pete Williamson
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Adds UMA for number of started attempts and for network connection when Unsupported Scheme error encountered. These changes are a follow-up to bug 642025 and the patch landed to mitigate it. They are meant to give us more visibility for tuning the policy for max number of started attempts for a request and whether we might use the network connection to better understand the nature of the Unsupported Scheme error. Also this reduces the max number of start attempts from 5 to 4. I tried 2 EM URLs that took 3 attempts on GIN-2g on GIN-2g-poor and one took only 2 attempts while the other took 4 attempts so I don't want to lower this too much yet (and see what new UMA reveals). BUG=642923 Review-Url: https://codereview.chromium.org/2301703002 Cr-Commit-Position: refs/heads/master@{#416101} (cherry picked from commit 22647f96af79fb0d563644640689a8fc678f15ac) Committed: https://chromium.googlesource.com/chromium/src/+/8d69874fb6de3c8c2e688cd264c416bb2c0fc906

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -26 lines) Patch
M chrome/browser/android/offline_pages/prerendering_loader.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M components/offline_pages/background/offliner_policy.h View 1 chunk +1 line, -1 line 0 comments Download
M components/offline_pages/background/request_coordinator.h View 1 chunk +9 lines, -0 lines 0 comments Download
M components/offline_pages/background/request_coordinator.cc View 4 chunks +44 lines, -25 lines 0 comments Download
M components/offline_pages/background/request_notifier.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Pete Williamson
4 years, 3 months ago (2016-09-06 21:01:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8d69874fb6de3c8c2e688cd264c416bb2c0fc906.

Powered by Google App Engine
This is Rietveld 408576698