Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 2314253002: Add check for null pointer (Closed)

Created:
4 years, 3 months ago by jrummell
Modified:
4 years, 3 months ago
Reviewers:
ddorwin
CC:
chromium-reviews, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, eric.carlson_apple.com, haraken, blink-reviews, Srirama
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add check for null pointer When resources are freed, asynchronous tasks may fail later and cause promises to be rejected. However, since the resource is gone, this crashes. Add a check that the ExecutionContext still exists before using it. BUG=644269 TEST=test case doesn't crash Committed: https://crrev.com/d0abaf6c13603474382963075424bf7586558d74 Cr-Commit-Position: refs/heads/master@{#416797}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/modules/encryptedmedia/ContentDecryptionModuleResultPromise.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
jrummell
PTAL
4 years, 3 months ago (2016-09-06 20:41:29 UTC) #2
ddorwin
lgtm
4 years, 3 months ago (2016-09-06 22:09:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314253002/1
4 years, 3 months ago (2016-09-06 22:27:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 00:32:42 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 00:35:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d0abaf6c13603474382963075424bf7586558d74
Cr-Commit-Position: refs/heads/master@{#416797}

Powered by Google App Engine
This is Rietveld 408576698