Remove calls to deprecated MessageLoop methods in ios.

Remove calls to deprecated MessageLoop methods in ios.

This CL (hopefully) removes all calls to these methods in ios:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
R=sdefresne@chromium.org

Committed: https://crrev.com/1dbfd37b66cea913f60d8069b3f9b0fe593d11a7
Cr-Commit-Position: refs/heads/master@{#417305}

[fdoray, 2016-09-06 20:26:49]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 20:27:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 21:17:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 21:17:22]

Dry run: This issue passed the CQ dry run.

[fdoray, 2016-09-06 21:56:39]

PTAL

[sdefresne, 2016-09-07 11:06:37]

https://codereview.chromium.org/2314243002/diff/1/ios/chrome/browser/browser_...
File ios/chrome/browser/browser_state/test_chrome_browser_state.mm (right):

https://codereview.chromium.org/2314243002/diff/1/ios/chrome/browser/browser_...
ios/chrome/browser/browser_state/test_chrome_browser_state.mm:382:
base::RunLoop().RunUntilIdle();
Why use a second base::RunLoop() object here instead of reusing the local
variable run_loop declared above?

https://codereview.chromium.org/2314243002/diff/1/ios/web/webui/url_data_mana...
File ios/web/webui/url_data_manager_ios_backend.mm (right):

https://codereview.chromium.org/2314243002/diff/1/ios/web/webui/url_data_mana...
ios/web/webui/url_data_manager_ios_backend.mm:20: #include "base/run_loop.h"
Why the include for base/run_loop.h? Seems unused.

[fdoray, 2016-09-07 13:15:58]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[fdoray, 2016-09-07 13:16:03]

PTAnL

https://codereview.chromium.org/2314243002/diff/1/ios/chrome/browser/browser_...
File ios/chrome/browser/browser_state/test_chrome_browser_state.mm (right):

https://codereview.chromium.org/2314243002/diff/1/ios/chrome/browser/browser_...
ios/chrome/browser/browser_state/test_chrome_browser_state.mm:382:
base::RunLoop().RunUntilIdle();
On 2016/09/07 11:06:36, sdefresne wrote:
> Why use a second base::RunLoop() object here instead of reusing the local
> variable run_loop declared above?

A RunLoop can't be reused.

In the latest patch set, I removed this line. Since |run_loop| is quit using
QuitWhenIdleClosure, we know that the MessageLoop is idle when line 378 returns
(and hence line 382 is useless).

https://codereview.chromium.org/2314243002/diff/1/ios/web/webui/url_data_mana...
File ios/web/webui/url_data_manager_ios_backend.mm (right):

https://codereview.chromium.org/2314243002/diff/1/ios/web/webui/url_data_mana...
ios/web/webui/url_data_manager_ios_backend.mm:20: #include "base/run_loop.h"
On 2016/09/07 11:06:37, sdefresne wrote:
> Why the include for base/run_loop.h? Seems unused.

Done.

[commit-bot: I haz the power, 2016-09-07 13:16:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 13:50:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 13:50:59]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2016-09-08 15:16:26]

lgtm

[fdoray, 2016-09-08 15:26:53]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-09-08 15:27:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 16:14:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-08 16:15:39]

Description was changed from

==========
Remove calls to deprecated MessageLoop methods in ios.

This CL (hopefully) removes all calls to these methods in ios:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
R=sdefresne@chromium.org
==========

to

==========
Remove calls to deprecated MessageLoop methods in ios.

This CL (hopefully) removes all calls to these methods in ios:
- MessageLoop::PostTask
- MessageLoop::PostDelayedTask
- MessageLoop::DeleteSoon
- MessageLoop::ReleaseSoon
- MessageLoop::Run
- MessageLoop::RunUntilIdle

BUG=616447
R=sdefresne@chromium.org

Committed: https://crrev.com/1dbfd37b66cea913f60d8069b3f9b0fe593d11a7
Cr-Commit-Position: refs/heads/master@{#417305}
==========

[commit-bot: I haz the power, 2016-09-08 16:15:40]

Patchset 2 (id:??) landed as
https://crrev.com/1dbfd37b66cea913f60d8069b3f9b0fe593d11a7
Cr-Commit-Position: refs/heads/master@{#417305}