Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2314233002: Remove calls to deprecated MessageLoop methods in ash. (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul, dcheng, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to deprecated MessageLoop methods in ash. This CL (hopefully) removes all calls to these methods in ash: - MessageLoop::PostTask - MessageLoop::PostDelayedTask - MessageLoop::DeleteSoon - MessageLoop::ReleaseSoon - MessageLoop::Run - MessageLoop::RunUntilIdle BUG=616447 R=sky@chromium.org Committed: https://crrev.com/c41a2ec2e985736ca8cec99f46b37ab9d3aadd2d Cr-Commit-Position: refs/heads/master@{#416921}

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M ash/common/system/chromeos/power/power_status_unittest.cc View 2 chunks +3 lines, -2 lines 2 comments Download
M ash/drag_drop/drag_drop_interactive_uitest.cc View 2 chunks +2 lines, -1 line 2 comments Download

Messages

Total messages: 12 (6 generated)
fdoray
PTAL
4 years, 3 months ago (2016-09-06 20:52:27 UTC) #3
sky
LGTM https://codereview.chromium.org/2314233002/diff/1/ash/common/system/chromeos/power/power_status_unittest.cc File ash/common/system/chromeos/power/power_status_unittest.cc (right): https://codereview.chromium.org/2314233002/diff/1/ash/common/system/chromeos/power/power_status_unittest.cc#newcode11 ash/common/system/chromeos/power/power_status_unittest.cc:11: #include "base/message_loop/message_loop.h" If you can, remove this include. ...
4 years, 3 months ago (2016-09-06 21:51:52 UTC) #6
fdoray
https://codereview.chromium.org/2314233002/diff/1/ash/common/system/chromeos/power/power_status_unittest.cc File ash/common/system/chromeos/power/power_status_unittest.cc (right): https://codereview.chromium.org/2314233002/diff/1/ash/common/system/chromeos/power/power_status_unittest.cc#newcode11 ash/common/system/chromeos/power/power_status_unittest.cc:11: #include "base/message_loop/message_loop.h" On 2016/09/06 21:51:52, sky wrote: > If ...
4 years, 3 months ago (2016-09-07 13:00:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314233002/1
4 years, 3 months ago (2016-09-07 13:00:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 13:04:05 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 13:05:15 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c41a2ec2e985736ca8cec99f46b37ab9d3aadd2d
Cr-Commit-Position: refs/heads/master@{#416921}

Powered by Google App Engine
This is Rietveld 408576698