Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 231423002: Always output seccomp error messages to stderr (Closed)

Created:
6 years, 8 months ago by hamaji
Modified:
6 years, 8 months ago
CC:
chromium-reviews, agl, jln+watch_chromium.org
Visibility:
Public.

Description

Always output seccomp error messages to stderr Also now we always use WriteToStderr and move comments to appropriate positions. TEST=trybots BUG=359285 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262829

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc View 4 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hamaji
Per https://codereview.chromium.org/196793023/
6 years, 8 months ago (2014-04-09 18:11:00 UTC) #1
jln (very slow on Chromium)
lgtm, thanks!
6 years, 8 months ago (2014-04-09 18:57:55 UTC) #2
jln (very slow on Chromium)
On 2014/04/09 18:57:55, jln wrote: > lgtm, thanks! Also, FYI, for Chromium bugs, just do ...
6 years, 8 months ago (2014-04-09 19:53:44 UTC) #3
hamaji
The CQ bit was checked by hamaji@chromium.org
6 years, 8 months ago (2014-04-09 20:12:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hamaji@chromium.org/231423002/1
6 years, 8 months ago (2014-04-09 20:12:52 UTC) #5
hamaji
On 2014/04/09 19:53:44, jln wrote: > On 2014/04/09 18:57:55, jln wrote: > > lgtm, thanks! ...
6 years, 8 months ago (2014-04-09 20:14:29 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 21:49:52 UTC) #7
Message was sent while issue was closed.
Change committed as 262829

Powered by Google App Engine
This is Rietveld 408576698