Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2314223002: Move CPDF_GraphState to CFX_GraphState (Closed)

Created:
4 years, 3 months ago by Tom Sepez
Modified:
4 years, 3 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Move CPDF_GraphState to CFX_GraphState The FX layer is spying on its private data, so make the job of ref-counting it live in FX as well, instead of up a layer at pdfapi. Pre-cursor to making this private and passing the graph state itself everywhere. Committed: https://pdfium.googlesource.com/pdfium/+/7c9f0a11e3dd890aa2ae13d5bb5460951d2111d8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -133 lines) Patch
M BUILD.gn View 3 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_graphicstates.h View 2 chunks +2 lines, -2 lines 0 comments Download
D core/fpdfapi/fpdf_page/cpdf_graphstate.h View 1 chunk +0 lines, -44 lines 0 comments Download
D core/fpdfapi/fpdf_page/cpdf_graphstate.cpp View 1 chunk +0 lines, -61 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fxge/ge/cfx_graphstate.cpp View 2 chunks +16 lines, -16 lines 0 comments Download
A + core/fxge/include/cfx_graphstate.h View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Tom Sepez
Dan, for review.
4 years, 3 months ago (2016-09-06 19:48:46 UTC) #3
dsinclair
lgtm
4 years, 3 months ago (2016-09-06 19:51:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314223002/1
4 years, 3 months ago (2016-09-06 19:51:42 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 20:02:57 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/7c9f0a11e3dd890aa2ae13d5bb5460951d21...

Powered by Google App Engine
This is Rietveld 408576698