Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: ash/mus/window_manager.cc

Issue 2314203002: Move DisplayList to display; add ScreenBase. (Closed)
Patch Set: Update unit test namespace. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/mus/window_manager.h ('k') | ash/test/display_manager_test_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/mus/window_manager.cc
diff --git a/ash/mus/window_manager.cc b/ash/mus/window_manager.cc
index aaf1aa1a6047bbac6a5a95a4216d2609566922e5..5ae3cc5776dd5f3e15b6d90d711622925ee5fea3 100644
--- a/ash/mus/window_manager.cc
+++ b/ash/mus/window_manager.cc
@@ -36,12 +36,7 @@
#include "ui/views/mus/pointer_watcher_event_router.h"
#include "ui/views/mus/screen_mus.h"
-namespace ash {
-namespace mus {
-
-void AssertTrue(bool success) {
- DCHECK(success);
-}
+namespace {
// TODO(jamescook): Port ash::sysui::AppListPresenterMus and eliminate this.
class AppListPresenterStub : public app_list::AppListPresenter {
@@ -66,6 +61,11 @@ class AppListPresenterStub : public app_list::AppListPresenter {
DISALLOW_COPY_AND_ASSIGN(AppListPresenterStub);
};
+} // namespace
+
+namespace ash {
+namespace mus {
+
WindowManager::WindowManager(shell::Connector* connector)
: connector_(connector) {}
@@ -161,7 +161,7 @@ void WindowManager::RemoveObserver(WindowManagerObserver* observer) {
RootWindowController* WindowManager::CreateRootWindowController(
ui::Window* window,
const display::Display& display) {
- // TODO(sky): there is timing issues with using ScreenMus.
+ // TODO(sky): There are timing issues with using ScreenMus.
if (!screen_) {
std::unique_ptr<views::ScreenMus> screen(new views::ScreenMus(nullptr));
screen->Init(connector_);
@@ -267,8 +267,7 @@ bool WindowManager::OnWmSetProperty(
ui::Window* window,
const std::string& name,
std::unique_ptr<std::vector<uint8_t>>* new_data) {
- // TODO(sky): constrain this to set of keys we know about, and allowed
- // values.
+ // TODO(sky): constrain this to set of keys we know about, and allowed values.
return name == ui::mojom::WindowManager::kShowState_Property ||
name == ui::mojom::WindowManager::kPreferredSize_Property ||
name == ui::mojom::WindowManager::kResizeBehavior_Property ||
« no previous file with comments | « ash/mus/window_manager.h ('k') | ash/test/display_manager_test_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698