third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js - Issue 2314173003: Timeline: make prepareHighlightedEntryInfo return ?Promise<!Element>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js

Issue 2314173003: Timeline: make prepareHighlightedEntryInfo return ?Promise<!Element> (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileFlameChart.js ('K') | « third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js ('k') | third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js » ('j') | third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js b/third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js

index 7bd41ee54faafbe3f6a561c5a50c21b98857377c..1a6d3dfb81585f00ce6e693072f23e4bd8b9edd1 100644

--- a/third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js

+++ b/third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js

@@ -409,7 +409,7 @@ WebInspector.HeapFlameChartDataProvider.prototype = {

/**

* @override

* @param {number} entryIndex

- * @return {?Array<!{title: string, value: (string|!Element)}>}

+ * @return {?Promise<!Element>}

prepareHighlightedEntryInfo: function(entryIndex)

{

@@ -433,7 +433,7 @@ WebInspector.HeapFlameChartDataProvider.prototype = {

if (link)

pushEntryInfoRow(WebInspector.UIString("URL"), link.textContent);

linkifier.dispose();

- return entryInfo;

+ return Promise.resolve(WebInspector.ProfileView.buildPopoverTable(entryInfo));

__proto__: WebInspector.ProfileFlameChartDataProvider.prototype